Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Use correct publish directory for netlify deploy #2741

Merged
merged 6 commits into from
Dec 13, 2022

Conversation

komali2
Copy link
Contributor

@komali2 komali2 commented Dec 8, 2022

Netlify automatically sets the Publish directory as "dist," but the netlify admin app's build command outputs files to public.

Netlify automatically sets the Publish directory as "dist," but the netlify admin app's `build` command outputs files to `public`.
@komali2 komali2 requested a review from a team as a code owner December 8, 2022 05:24
@changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2022

⚠️ No Changeset found

Latest commit: c785c21

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@olivermrbl olivermrbl changed the title Use correct publish directory for netlify deploy docs: Use correct publish directory for netlify deploy Dec 8, 2022
Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I left some comments for changes below.

In addition, we should make changes to the CLI steps. Can you change the "Last Step: Steps with Default Values" section to indicate:

  1. Set build command:
? Your build command (hugo build/yarn run build/etc): yarn run build

Set deploy directory:

? Directory to deploy (blank for current dir): public

docs/content/deployments/admin/deploying-on-netlify.md Outdated Show resolved Hide resolved
docs/content/deployments/admin/deploying-on-netlify.md Outdated Show resolved Hide resolved
Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I left some comments for changes below.

In addition, we should make changes to the CLI steps. Can you change the "Last Step: Steps with Default Values" section to indicate:

  1. Set build command:
? Your build command (hugo build/yarn run build/etc): yarn run build

Set deploy directory:

? Directory to deploy (blank for current dir): public

Co-authored-by: Shahed Nasser <shahednasser@gmail.com>
@komali2
Copy link
Contributor Author

komali2 commented Dec 9, 2022

Thank you for your contribution! I left some comments for changes below.

In addition, we should make changes to the CLI steps. Can you change the "Last Step: Steps with Default Values" section to indicate:

1. Set build command:
? Your build command (hugo build/yarn run build/etc): yarn run build

Set deploy directory:

? Directory to deploy (blank for current dir): public

I will take some time later to understand this better. I'm not exactly sure what you mean yet.

@komali2
Copy link
Contributor Author

komali2 commented Dec 9, 2022

Thank you for your contribution! I left some comments for changes below.
In addition, we should make changes to the CLI steps. Can you change the "Last Step: Steps with Default Values" section to indicate:

1. Set build command:
? Your build command (hugo build/yarn run build/etc): yarn run build

Set deploy directory:

? Directory to deploy (blank for current dir): public

I will take some time later to understand this better. I'm not exactly sure what you mean yet.

oh, i understand, yes, I can do this.

@shahednasser
Copy link
Member

@komali2 any update on this? 😊

@shahednasser shahednasser merged commit 9021037 into medusajs:master Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants