Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update netlify deploy readme for clarity #2748

Merged
merged 3 commits into from
Dec 13, 2022

Conversation

komali2
Copy link
Contributor

@komali2 komali2 commented Dec 9, 2022

It was unlcear why "Gatsby" was mentioned in the env name for the server URL. Also, the code shows precedence given to MEDUSA_BACKEND_URL now:

    __MEDUSA_BACKEND_URL__: JSON.stringify(
      env.MEDUSA_BACKEND_URL ||
        // Backwards-compat with Gatsby.
        env.GATSBY_MEDUSA_BACKEND_URL ||
        env.GATSBY_STORE_URL ||
        ""
    ),

Therefore, this should be indicated in the documentation.

It was unlcear why "Gatsby" was mentioned in the env name for the server URL. Also, the code shows precedence given to `MEDUSA_BACKEND_URL` now:

```
    __MEDUSA_BACKEND_URL__: JSON.stringify(
      env.MEDUSA_BACKEND_URL ||
        // Backwards-compat with Gatsby.
        env.GATSBY_MEDUSA_BACKEND_URL ||
        env.GATSBY_STORE_URL ||
        ""
    ),
```

Therefore, this should be indicated in the documentation.
@komali2 komali2 requested a review from a team as a code owner December 9, 2022 06:08
@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2022

⚠️ No Changeset found

Latest commit: b256a9d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this change! I've added some comments below

docs/content/deployments/admin/deploying-on-netlify.md Outdated Show resolved Hide resolved
Comment on lines 232 to 238
Where `<YOUR_SERVER_URL>` is the URL of your Medusa server. Note that the usage of `GATSBY` in the environment variable name doesn't mean you can only use Gatsby frontend starters. For backwards compatibility, the following environment variable names are all valid and will all result with your Medusa Admin app communicating with the provided value as your Medusa server. Use any one of:

1. `GATSBY_MEDUSA_BACKEND_URL`
2. `GATSBY_STORE_URL`
3. `MEDUSA_BACKEND_URL`

If you define multiple environment variables with the above names, precedence will be given to `MEDUSA_BACKEND_URL`, and the others will be ignored (even if `MEDUSA_BACKEND_URL` is an invalid URL).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revert this back to the text that was before "Where <YOUR_SERVER_URL> is the URL of your Medusa server." and instead add a note saying something like "Previous versions of the Medusa admin use GATSBY_MEDUSA_BACKEND_URL or GATSBY_STORE_URL. Although the Admin is backwards compatible, it is advised to change the variable to MEDUSA_BACKEND_URL".

@shahednasser
Copy link
Member

@komali2 any update on this? 😊

@shahednasser shahednasser merged commit 6b51dd0 into medusajs:master Dec 13, 2022
@komali2
Copy link
Contributor Author

komali2 commented Mar 1, 2023

Thanks for adding changes! I got overwhelmed at work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants