-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(medusa): Update line item adjustments upon cart discount removal #2751
fix(medusa): Update line item adjustments upon cart discount removal #2751
Conversation
🦋 Changeset detectedLatest commit: acd407e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: We also allow you to remove discounts by sending:
POST /store/carts/{id}
{ discounts: [] }
So we should also fix the update cart flow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a minor todo before we merge 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What
When a discount is deleted from a cart, the line item adjustments must be refreshed. Now, the cart service
removeDiscount
includes updating the adjustments.Tests
Add a new integration test which:
Update unit tests
The actual tests cases now check that the adjustments repository is called when needed
FIXES CORE-890