Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getConfigFile typings #2783

Merged
merged 3 commits into from
Dec 14, 2022
Merged

fix: getConfigFile typings #2783

merged 3 commits into from
Dec 14, 2022

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Dec 13, 2022

What
Fix the return type of the get config file function. This should not break the API

@changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2022

🦋 Changeset detected

Latest commit: d42b6ed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
medusa-core-utils Patch
@medusajs/medusa Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@adrien2p adrien2p marked this pull request as ready for review December 13, 2022 10:14
@adrien2p adrien2p requested a review from a team as a code owner December 13, 2022 10:14
@adrien2p adrien2p force-pushed the fix/get-config-file-typings branch from 1a111f8 to 308bf70 Compare December 14, 2022 09:45
Copy link
Contributor

@pKorsholm pKorsholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@adrien2p adrien2p force-pushed the fix/get-config-file-typings branch from 308bf70 to 0466d5d Compare December 14, 2022 13:40
@olivermrbl olivermrbl merged commit 7cced60 into develop Dec 14, 2022
@olivermrbl olivermrbl deleted the fix/get-config-file-typings branch December 14, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants