Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(medusa-file-s3): Allow all AWS options in config #2809

Merged
merged 10 commits into from
Dec 20, 2022

Conversation

pKorsholm
Copy link
Contributor

@pKorsholm pKorsholm commented Dec 15, 2022

What

  • Allow an aws config object to be passed as plugin config

@changeset-bot
Copy link

changeset-bot bot commented Dec 15, 2022

🦋 Changeset detected

Latest commit: 4e7bf6e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
medusa-file-s3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pKorsholm
Copy link
Contributor Author

/snapshot-this

@pKorsholm
Copy link
Contributor Author

/snapshot-this

@github-actions
Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/medusa@1.7.1-snapshot-20221215114406
yarn add medusa-core-utils@1.1.37-snapshot-20221215114406
yarn add medusa-file-minio@1.1.2-snapshot-20221215114406
yarn add medusa-file-s3@1.1.8-snapshot-20221215114406
yarn add medusa-file-spaces@1.3.2-snapshot-20221215114406
yarn add medusa-fulfillment-manual@1.1.33-snapshot-20221215114406
yarn add medusa-fulfillment-webshipper@1.3.4-snapshot-20221215114406
yarn add @medusajs/medusa-js@1.3.5-snapshot-20221215114406
yarn add medusa-payment-adyen@1.1.40-snapshot-20221215114406
yarn add medusa-payment-klarna@1.3.5-snapshot-20221215114406
yarn add medusa-payment-manual@1.0.18-snapshot-20221215114406
yarn add medusa-payment-stripe@1.1.50-snapshot-20221215114406
yarn add medusa-plugin-algolia@0.2.6-snapshot-20221215114406
yarn add medusa-plugin-contentful@1.2.4-snapshot-20221215114406
yarn add medusa-plugin-discount-generator@1.1.21-snapshot-20221215114406
yarn add medusa-plugin-economic@1.1.39-snapshot-20221215114406
yarn add medusa-plugin-ip-lookup@1.2.2-snapshot-20221215114406
yarn add medusa-plugin-mailchimp@1.1.43-snapshot-20221215114406
yarn add medusa-plugin-meilisearch@1.0.1-snapshot-20221215114406
yarn add medusa-plugin-restock-notification@2.0.1-snapshot-20221215114406
yarn add medusa-plugin-segment@1.3.1-snapshot-20221215114406
yarn add medusa-plugin-sendgrid@1.3.4-snapshot-20221215114406
yarn add medusa-plugin-slack-notification@1.3.5-snapshot-20221215114406
yarn add medusa-plugin-twilio-sms@1.2.4-snapshot-20221215114406
yarn add medusa-plugin-wishlist@1.1.38-snapshot-20221215114406
yarn add medusa-react@4.0.1-snapshot-20221215114406
yarn add medusa-source-shopify@1.2.4-snapshot-20221215114406

Latest commit: e5e13cc

@pKorsholm pKorsholm marked this pull request as ready for review December 16, 2022 09:01
@pKorsholm pKorsholm requested a review from a team as a code owner December 16, 2022 09:01
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the readme to reflect those changes?

@pKorsholm pKorsholm requested a review from a team as a code owner December 16, 2022 12:01
Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some changes to the documentation based on our writing/style guide, hope that's fine 😄. If there are inaccuracies feel free to make the necessary changes.

docs/content/add-plugins/s3.md Outdated Show resolved Hide resolved
pKorsholm and others added 2 commits December 20, 2022 09:35
@olivermrbl olivermrbl changed the title initial options proposal feat(medusa-file-s3): Allow all AWS options in config Dec 20, 2022
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@olivermrbl olivermrbl merged commit 79cddc2 into develop Dec 20, 2022
@olivermrbl olivermrbl deleted the feat/s3-options branch December 20, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants