Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Set up your development doc for Medusa CLI section #2866

Merged
merged 3 commits into from
Dec 21, 2022
Merged

Update Set up your development doc for Medusa CLI section #2866

merged 3 commits into from
Dec 21, 2022

Conversation

debashiscodes
Copy link
Contributor

@debashiscodes debashiscodes commented Dec 20, 2022 •
edited
Loading

closes #2852

@debashiscodes debashiscodes requested a review from a team as a code owner December 20, 2022 20:09
@changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 157a1cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

shahednasser
shahednasser requested changes Dec 21, 2022
View reviewed changes
Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking up this issue @debashiscodes ! Just a small suggested change below.

docs/content/tutorial/0-set-up-your-development-environment.mdx Outdated Show resolved Hide resolved
@debashiscodes @shahednasser
Update docs/content/tutorial/0-set-up-your-development-environment.mdx
157a1cc 
Co-authored-by: Shahed Nasser <shahednasser@gmail.com>
@debashiscodes
Copy link
Contributor Author

Thanks, @shahednasser for your review.

shahednasser
shahednasser approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution @debashiscodes

@shahednasser shahednasser merged commit 34b5b63 into medusajs:master Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahednasser shahednasser shahednasser approved these changes

Assignees
No one assigned
Labels
type: docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: add a code block to test out Medusa CLI after installing it
2 participants
@debashiscodes @shahednasser