feat(medusa): Add ProductVariantInventoryService #2883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a18936c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pKorsholm
force-pushed
the
feat/add-product-variant-inventory-service
branch
from
c791cca to
cf5063d
Compare
srindom
reviewed
Dec 27, 2022
| @@ -14,8 +14,14 @@ import { | |||
| AbstractCartCompletionStrategy, | |||
| CartCompletionResponse, | |||
| } from "../interfaces" | |||
| import { | |||
There was a problem hiding this comment.
thought (this-file): this flow is great for @carlos-r-l-rodrigues' transaction orchestrator.
olivermrbl
requested changes
Dec 28, 2022
olivermrbl
reviewed
Dec 29, 2022
olivermrbl
approved these changes
Dec 29, 2022
| } else { | ||
| await lineItemServiceTx.delete(item.id) | ||
| return | ||
| return item |
There was a problem hiding this comment.
suggestion to make this block easier to read
cart.items = (
await Promise.all(
cart.items.map(async (item) => {
if (!item.variant_id) {
return item
}
const availablePrice = await this.priceSelectionStrategy_
.withTransaction(transactionManager)
.calculateVariantPrice(item.variant_id, {
region_id: region.id,
currency_code: region.currency_code,
quantity: item.quantity,
customer_id: customer_id || cart.customer_id,
include_discount_prices: true,
})
.catch(() => undefined)
if (
!isDefined(availablePrice) ||
availablePrice.calculatedPrice === null
) {
return await lineItemServiceTx.delete(item.id)
}
return await lineItemServiceTx.update(item.id, {
has_shipping: false,
unit_price: availablePrice.calculatedPrice,
})
})
)
)| .withTransaction(manager) | ||
| .update(variantId, { | ||
| inventory_quantity: variant.inventory_quantity + quantity, | ||
| }) |
There was a problem hiding this comment.
suggestion:
return here and remove the else block
pKorsholm
force-pushed
the
feat/add-product-variant-inventory-service
branch
from
4c8245b to
b296651
Compare
pKorsholm
force-pushed
the
feat/add-product-variant-inventory-service
branch
from
d5f5a24 to
b296651
Compare
srindom
approved these changes
Dec 29, 2022
There was a problem hiding this comment.
LGTM w. comments - also think @carlos-r-l-rodrigues' suggestions are worth considering including
Comment on lines
+282
to
+310
| await Promise.all( | ||
| cart.items.map(async (item) => { | ||
| if (item.variant_id) { | ||
| const inventoryConfirmed = | ||
| await productVariantInventoryServiceTx.confirmInventory( | ||
| item.variant_id, | ||
| item.quantity, | ||
| { salesChannelId: cart.sales_channel_id } | ||
| ) | ||
|
|
||
| if (!inventoryConfirmed) { | ||
| throw new MedusaError( | ||
| MedusaError.Types.NOT_ALLOWED, | ||
| `Variant with id: ${item.variant_id} does not have the required inventory`, | ||
| MedusaError.Codes.INSUFFICIENT_INVENTORY | ||
| ) | ||
| } | ||
|
|
||
| await productVariantInventoryServiceTx.reserveQuantity( | ||
| item.variant_id, | ||
| item.quantity, | ||
| { | ||
| lineItemId: item.id, | ||
| salesChannelId: cart.sales_channel_id, | ||
| } | ||
| ) | ||
| } | ||
| }) | ||
| ) |
There was a problem hiding this comment.
thought: this should probably go into its own step -- but let's not do anything, as we will refactor to the transaction orchestrator in any case.
carlos-r-l-rodrigues
approved these changes
Dec 29, 2022
olivermrbl
changed the title
|
Ready to merge? 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
sales-channel-inventorysales-channel-locationproduct-variant-inventoryinventoryServicepicks out the core parts of #2459
Fixes CORE-914, CORE-912