Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: add git as in the prerequisites section of the Quickstart Guide #2892

Merged
merged 2 commits into from
Dec 27, 2022
Merged

Docs: add git as in the prerequisites section of the Quickstart Guide #2892

merged 2 commits into from
Dec 27, 2022

Conversation

akarsh-jain-790
Copy link
Contributor

@akarsh-jain-790 akarsh-jain-790 requested a review from a team as a code owner December 23, 2022 03:15
@changeset-bot
Copy link

changeset-bot bot commented Dec 23, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1eb3884

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@akarsh-jain-790 akarsh-jain-790 force-pushed the docs/add-git-in-the-prerequisites-of-Quickstart-Guide branch 2 times, most recently from 301a2f2 to c4f8cb2 Compare December 23, 2022 04:19
shahednasser
shahednasser requested changes Dec 23, 2022
View reviewed changes
Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @akarsh-jain-790 ! Instead of adding all the steps, can you just add that git is required with a link to how to install it from the Set up your dev environment documentation?

@akarsh-jain-790 akarsh-jain-790 force-pushed the docs/add-git-in-the-prerequisites-of-Quickstart-Guide branch from c4f8cb2 to a6cbfe5 Compare December 24, 2022 08:00
@akarsh-jain-790
Copy link
Contributor Author

Thank you for your contribution @akarsh-jain-790 ! Instead of adding all the steps, can you just add that git is required with a link to how to install it from the Set up your dev environment documentation?

@shahednasser I have updated the PR, you can re-review now.

shahednasser
shahednasser requested changes Dec 26, 2022
View reviewed changes
Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you added a subheader "Git" can you add one for Node.js as well?

@akarsh-jain-790
Copy link
Contributor Author

Since you added a subheader "Git" can you add one for Node.js as well?

Sure, will add a subheader for Node.js as well.

@akarsh-jain-790 akarsh-jain-790 force-pushed the docs/add-git-in-the-prerequisites-of-Quickstart-Guide branch from a6cbfe5 to 66fa05f Compare December 27, 2022 03:06
@akarsh-jain-790
Copy link
Contributor Author

Click here to learn what changesets are, and how to add one

Done, you can review now.

@shahednasser shahednasser merged commit 48baf48 into medusajs:master Dec 27, 2022
@shahednasser
Copy link
Member

Thanks! @akarsh-jain-790

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahednasser shahednasser shahednasser approved these changes

Assignees
No one assigned
Labels
type: docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: add git as in the prerequisites section of the Quickstart Guide
2 participants
@akarsh-jain-790 @shahednasser