Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(medusa): search orders by customer phone and name #2913

Merged
merged 5 commits into from
Dec 29, 2022
Merged

Feat(medusa): search orders by customer phone and name #2913

merged 5 commits into from
Dec 29, 2022

Conversation

pKorsholm
Copy link
Contributor

@pKorsholm pKorsholm commented Dec 29, 2022 •
edited
Loading

What

  • add customer phone and name to queryable fields when searching orders

Testing

  • Add integration tests for querying orders by customer first- and last name as well as phone

Fixes CORE-939

@pKorsholm pKorsholm requested a review from a team as a code owner December 29, 2022 10:36
@changeset-bot
Copy link

changeset-bot bot commented Dec 29, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 745d80e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/medusa Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pKorsholm pKorsholm requested a review from olivermrbl December 29, 2022 12:12
olivermrbl
olivermrbl approved these changes Dec 29, 2022
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice one!

@pKorsholm pKorsholm merged commit 645e0d0 into develop Dec 29, 2022
@pKorsholm pKorsholm deleted the feat/search-orders-by-phone-and-name branch December 29, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pKorsholm @olivermrbl