Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(integration): Randomize option value name #2918

Merged
merged 3 commits into from
Dec 29, 2022
Merged

tests(integration): Randomize option value name #2918

merged 3 commits into from
Dec 29, 2022

Conversation

pKorsholm
Copy link
Contributor

@pKorsholm pKorsholm commented Dec 29, 2022 •
edited
Loading

What

  • update the id of product option values in the factory

Why

  • The primary key constraint on product-option-value occasionally causes our integration tests to break at order totals. This might help that.

@pKorsholm pKorsholm requested a review from a team as a code owner December 29, 2022 14:57
@changeset-bot
Copy link

changeset-bot bot commented Dec 29, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: b7556fe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

olivermrbl
olivermrbl approved these changes Dec 29, 2022
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@olivermrbl olivermrbl changed the title Fix(medusa): option value constraint fix tests(integration): Randomize option value name Dec 29, 2022
@olivermrbl olivermrbl merged commit 90d774f into develop Dec 29, 2022
@olivermrbl olivermrbl deleted the fix/option-value-constraint-fix branch December 29, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pKorsholm @olivermrbl