-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(medusa): Update payment session management #2937
Conversation
🦋 Changeset detectedLatest commit: 7397483 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bb07143
to
dd67f8b
Compare
9cf73b2
to
ad0a1f3
Compare
I ll perform some tests through my scripts. We should also plan some tests on staging around this chore |
From the tests, we can see that only one payment is created for the active session instead of one payment for each session no matter the one that the customer selects. We can also see that only once customer is created as well as one intent and this intent is updated twice, one for each cart manipulation post session selection |
/snapshot-this |
I ll continue the test locally for now |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/medusa@1.7.3-snapshot-20230106120456 yarn add @medusajs/medusa-js@1.3.6-snapshot-20230106120456 yarn add @medusajs/stock-location@2.0.0-snapshot-20230106120456
|
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/medusa@1.7.3-snapshot-20230106122348 yarn add @medusajs/medusa-js@1.3.6-snapshot-20230106122348 yarn add @medusajs/stock-location@2.0.0-snapshot-20230106122348
|
I've done some payment tests on this snapshot with multiple stripe providers. All went fine :) |
9a08bac
to
4eb68c9
Compare
@olivermrbl for the existing payment session, I wanted to add a migration that set them as is_initiated if there have some data? What do you think? should I proceed? |
@adrien2p Yes, I think that is an excellent idea 👍 |
Do you want to add it in this PR or a subsequent one? |
I will add it in that one 👌e |
@srindom Do you have any final comments before we merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, strong work! 🚀
What
Update the session management in the cart checkout flow.