chore(feature-flags): Sales Channels enabled by default #2966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9212d14 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…a into chore/sc-ff-default-value
adrien2p
approved these changes
Jan 10, 2023
integration-tests/api/__tests__/store/__snapshots__/product-variants.js.snap
Show resolved
Hide resolved
| await manager.insert(Product, { | ||
| id: "test-product", | ||
| title: "test product", | ||
| profile_id: defaultProfile.id, | ||
| options: [{ id: "test-option", title: "Size" }], | ||
| }) | ||
|
|
||
| await manager.query( |
There was a problem hiding this comment.
suggestion: should it be part of the product factory? we pass a sales channel and it creates the pivot along it if it is not managed by the ORM
| @@ -44,6 +54,10 @@ module.exports = async (connection, data = {}) => { | |||
| options: [{ id: "test-option-color", title: "Color" }], | |||
| }) | |||
|
|
|||
| await manager.query( | |||
| await manager.insert(Product, { | ||
| id: "test-product", | ||
| title: "test product", | ||
| profile_id: defaultProfile.id, | ||
| options: [{ id: "test-option", title: "Size" }], | ||
| }) | ||
|
|
||
| await manager.query( |
packages/medusa/src/api/routes/admin/orders/__tests__/get-order.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.