-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(medusa-react): Upgrade react-query and clean up dependencies #2969
Conversation
🦋 Changeset detectedLatest commit: 7ff4453 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/medusa@1.7.3-snapshot-20230109142834 yarn add @medusajs/medusa-js@1.3.6-snapshot-20230109142834 yarn add @medusajs/stock-location@2.0.0-snapshot-20230109142834
|
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/medusa@1.7.3-snapshot-20230109144732 yarn add @medusajs/medusa-js@1.3.6-snapshot-20230109144732 yarn add medusa-react@4.0.2-snapshot-20230109144732 yarn add @medusajs/stock-location@2.0.0-snapshot-20230109144732
|
This would fit well in the upgrade guide for 1.7.3 @shahednasser 😊 |
@olivermrbl I'll add it to the open PR |
LGTM but will keep it out of upcoming release to not introduce unnecessary required actions for v1.7.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What
react-query
->@tanstack/react-query
(v4)react-query
as it should only be apeer- and devDependency
.Why
react-query
being both a direct and peer dependency it could resolve in multiple versions ofreact-query
being bundled in the production build of users' projects. This results in the errorNo QueryClient set, use QueryClientProvider to set one
being thrown.react-query
plays better with Vite, and due to that the upgrade has been included. This will require users to update their version ofreact-query
->@tanstack/react-query@^4
to continue usingmedusa-react
.Resolves CORE-972