Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added publishable API keys documentation pages #2972

Merged
merged 8 commits into from
Jan 11, 2023

Conversation

shahednasser
Copy link
Member

  • Added conceptual guide for publishable API keys
  • Added an admin how-to guide for managing publishable API keys
  • Added a user guide how-to guide for managing publishable API keys on the admin
  • Fixes to OAS of publishable API keys admin endpoints
  • Small fixes in other documentation pages

Closes DOCS-437, DOCS-438, DOCS-440, DOCS-441

@shahednasser shahednasser requested review from a team as code owners January 9, 2023 18:23
@changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2023

⚠️ No Changeset found

Latest commit: ebf1936

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@fPolic fPolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @shahednasser!
Have just 2 minor comments

shahednasser and others added 2 commits January 10, 2023 09:56
Co-authored-by: Frane Polić <16856471+fPolic@users.noreply.github.com>
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpicking. Feel free to discard the comments. Just added them while giving it another read 😊


Currently, publishable API keys can only be associated with sales channels.

Using the Admin APIs, you can manage your Publishable API Keys.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion(non-blocking): Omit this as this is trivial

Suggested change
Using the Admin APIs, you can manage your Publishable API Keys.


Taking Sales Channels as an example, you have to pass the Sales Channel’s ID as a query parameter to all the necessary endpoints, such as the List Products endpoint.

As this approach can be error-prone, Publishable API Keys solve this problem.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion(non-blocking):

Suggested change
As this approach can be error-prone, Publishable API Keys solve this problem.
This is a tedious and error-prone process, which is why we introduce Publishable API Keys.

})
```

Then, the API key will be passed in the header parameter `x-publishable-api-key` of every request.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion(non-blocking):

Suggested change
Then, the API key will be passed in the header parameter `x-publishable-api-key` of every request.
This will add the API key as a header, `x-publishable-api-key`, on all requests.

shahednasser and others added 2 commits January 11, 2023 10:03
Co-authored-by: Oliver Windall Juhl <59018053+olivermrbl@users.noreply.github.com>
@shahednasser shahednasser merged commit 4156e28 into master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants