-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: added publishable API keys documentation pages #2972
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @shahednasser!
Have just 2 minor comments
Co-authored-by: Frane Polić <16856471+fPolic@users.noreply.github.com>
Co-authored-by: Oliver Windall Juhl <59018053+olivermrbl@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpicking. Feel free to discard the comments. Just added them while giving it another read 😊
|
||
Currently, publishable API keys can only be associated with sales channels. | ||
|
||
Using the Admin APIs, you can manage your Publishable API Keys. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion(non-blocking): Omit this as this is trivial
Using the Admin APIs, you can manage your Publishable API Keys. |
|
||
Taking Sales Channels as an example, you have to pass the Sales Channel’s ID as a query parameter to all the necessary endpoints, such as the List Products endpoint. | ||
|
||
As this approach can be error-prone, Publishable API Keys solve this problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion(non-blocking):
As this approach can be error-prone, Publishable API Keys solve this problem. | |
This is a tedious and error-prone process, which is why we introduce Publishable API Keys. |
}) | ||
``` | ||
|
||
Then, the API key will be passed in the header parameter `x-publishable-api-key` of every request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion(non-blocking):
Then, the API key will be passed in the header parameter `x-publishable-api-key` of every request. | |
This will add the API key as a header, `x-publishable-api-key`, on all requests. |
Co-authored-by: Oliver Windall Juhl <59018053+olivermrbl@users.noreply.github.com>
Closes DOCS-437, DOCS-438, DOCS-440, DOCS-441