Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(medusa): Migrate setPaymentSession to use new session flow #2982

Merged
merged 1 commit into from
Jan 11, 2023
Merged

feat(medusa): Migrate setPaymentSession to use new session flow #2982

merged 1 commit into from
Jan 11, 2023

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Jan 10, 2023 •
edited
Loading

What
When selecting a payment session, we do not necessarily run setPaymentSessions. manage the previously selected session.m accordingly.

@changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5aeb5fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@adrien2p adrien2p changed the title Feat/payment selection remove remote session Feat(medusa): cart payment selection should remove the previous selected remote session Jan 10, 2023
@adrien2p adrien2p marked this pull request as ready for review January 10, 2023 20:04
@adrien2p adrien2p requested a review from a team as a code owner January 10, 2023 20:04
@adrien2p adrien2p force-pushed the feat/payment-selection-remove-remote-session branch from 5aeb5fb to 9116d6b Compare January 11, 2023 08:56
@adrien2p
Copy link
Member Author

Screenshot 2023-01-11 at 09 57 35

Screenshot 2023-01-11 at 09 57 55

@adrien2p
Copy link
Member Author

/snapshot-this

@github-actions
Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/medusa@1.7.3-snapshot-20230111090250
yarn add @medusajs/medusa-js@1.3.6-snapshot-20230111090250
yarn add medusa-payment-manual@1.0.19-snapshot-20230111090250
yarn add medusa-test-utils@1.1.38-snapshot-20230111090250
yarn add @medusajs/stock-location@1.0.1-snapshot-20230111090250

Latest commit: 21b1ae5

@olivermrbl olivermrbl changed the title Feat(medusa): cart payment selection should remove the previous selected remote session feat(medusa): Migrate setPaymentSession to use setPaymentSessions logic Jan 11, 2023
olivermrbl
olivermrbl approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@olivermrbl olivermrbl closed this Jan 11, 2023
@olivermrbl olivermrbl reopened this Jan 11, 2023
@olivermrbl olivermrbl changed the title feat(medusa): Migrate setPaymentSession to use setPaymentSessions logic feat(medusa): Migrate setPaymentSession to use new session flow Jan 11, 2023
@kodiakhq kodiakhq bot merged commit 6239fa0 into develop Jan 11, 2023
@kodiakhq kodiakhq bot deleted the feat/payment-selection-remove-remote-session branch January 11, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrien2p @olivermrbl