feat(medusa): added admin create endpoint for nested categories #2985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bbc0b3e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
riqwan
force-pushed
the
feat/nested-category-create-endpoint
branch
from
b0dd13e to
0357518
Compare
riqwan
force-pushed
the
feat/nested-category-create-endpoint
branch
from
0357518 to
d8d59f6
Compare
adrien2p
requested changes
Jan 11, 2023
packages/medusa/src/api/routes/admin/product-categories/create-product-category.ts
Outdated
Show resolved
Hide resolved
packages/medusa/src/api/routes/admin/product-categories/create-product-category.ts
Outdated
Show resolved
Hide resolved
packages/medusa/src/api/routes/admin/product-categories/create-product-category.ts
Outdated
Show resolved
Hide resolved
packages/medusa/src/api/routes/admin/product-categories/create-product-category.ts
Show resolved
Hide resolved
pKorsholm
approved these changes
Jan 11, 2023
riqwan
force-pushed
the
feat/nested-category-create-endpoint
branch
from
7311999 to
98d2f93
Compare
|
@adrien2p Will you revisit your review, so we can merge? :) |
adrien2p
reviewed
Jan 11, 2023
| @@ -41,14 +42,18 @@ export class ProductCategory extends SoftDeletableEntity { | |||
|
|
|||
| // Typeorm also keeps track of the category's parent at all times. | |||
| @Column() | |||
| parent_category_id: ProductCategory | |||
| parent_category_id: string | null | |||
adrien2p
reviewed
Jan 11, 2023
|
|
||
| const api = useApi() | ||
|
|
||
| const response = await api.post( |
There was a problem hiding this comment.
non blocking: should we add a tests without passing the handle to also assert that this behaviour do not broke at some point?
adrien2p
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Introduces an admin endpoint that allows a user to create a product category
Why:
This is part of a greater goal of allowing products to be added to multiple categories.
How:
RESOLVES CORE-958