Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(medusa): Nested Categories Admin Update Endpoint #2986

Merged
merged 22 commits into from
Jan 11, 2023

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Jan 11, 2023

What:

Introduces an admin endpoint that allows a user to update a product category

Why:

This is part of a greater goal of allowing products to be added to multiple categories.

How:

  • Creates a route on the admin scope to update category
  • Creates a method in product category services to update a category

RESOLVES CORE-956

@changeset-bot
Copy link

changeset-bot bot commented Jan 11, 2023

🦋 Changeset detected

Latest commit: ddefcab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/medusa Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@riqwan riqwan force-pushed the feat/nested-category-update-endpoint branch from bc85672 to ff45176 Compare January 11, 2023 10:51
@riqwan riqwan force-pushed the feat/nested-category-update-endpoint branch from 8e109a0 to a23b73e Compare January 11, 2023 12:05
@riqwan riqwan marked this pull request as ready for review January 11, 2023 12:05
@riqwan riqwan requested a review from a team as a code owner January 11, 2023 12:05
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strong work! Only a minor todo 💯

Also, think @pKorsholm's suggestion to add events is great. For update and create :)

packages/medusa/src/services/product-category.ts Outdated Show resolved Hide resolved
Co-authored-by: Oliver Windall Juhl <59018053+olivermrbl@users.noreply.github.com>
@olivermrbl
Copy link
Contributor

Also, missing changeset :)

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@pKorsholm pKorsholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Only have a couple of non-blocking nit-picks 😄

riqwan and others added 2 commits January 11, 2023 13:42
…-product-category.ts

Co-authored-by: Philip Korsholm <88927411+pKorsholm@users.noreply.github.com>
Co-authored-by: Philip Korsholm <88927411+pKorsholm@users.noreply.github.com>
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from feat/nested-category-create-endpoint to develop January 11, 2023 14:51
@kodiakhq kodiakhq bot merged commit aab163b into develop Jan 11, 2023
@kodiakhq kodiakhq bot deleted the feat/nested-category-update-endpoint branch January 11, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants