-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(medusa): Nested Categories Admin Update Endpoint #2986
Conversation
🦋 Changeset detectedLatest commit: ddefcab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bc85672
to
ff45176
Compare
8e109a0
to
a23b73e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strong work! Only a minor todo 💯
Also, think @pKorsholm's suggestion to add events is great. For update and create :)
Co-authored-by: Oliver Windall Juhl <59018053+olivermrbl@users.noreply.github.com>
Also, missing changeset :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Only have a couple of non-blocking nit-picks 😄
packages/medusa/src/api/routes/admin/product-categories/update-product-category.ts
Show resolved
Hide resolved
packages/medusa/src/api/routes/admin/product-categories/update-product-category.ts
Show resolved
Hide resolved
packages/medusa/src/api/routes/admin/product-categories/update-product-category.ts
Show resolved
Hide resolved
…-product-category.ts Co-authored-by: Philip Korsholm <88927411+pKorsholm@users.noreply.github.com>
Co-authored-by: Philip Korsholm <88927411+pKorsholm@users.noreply.github.com>
…category-update-endpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What:
Introduces an admin endpoint that allows a user to update a product category
Why:
This is part of a greater goal of allowing products to be added to multiple categories.
How:
RESOLVES CORE-956