Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(oas): fixed oas for product category endpoints and model #3014

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

shahednasser
Copy link
Member

  • Fixed some inconsistencies in the OAS comments of product category endpoints and model.
  • Removed JS Client snippets since it's still not implemented in the JS Client.

Closes DOCS-451

@shahednasser shahednasser requested a review from a team as a code owner January 12, 2023 16:06
@changeset-bot
Copy link

changeset-bot bot commented Jan 12, 2023

⚠️ No Changeset found

Latest commit: cc56a27

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@patrick-medusajs patrick-medusajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤸

Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@shahednasser shahednasser merged commit 5d769cc into develop Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants