-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(medusa): List (service + controller) product categories #3004 #3023
Conversation
🦋 Changeset detectedLatest commit: 5207eca The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💪
* - (query) q {string} Query used for searching product category names orhandles. | ||
* - (query) parent_category_id {string} Returns categories scoped by parent | ||
* - (query) offset=0 {integer} How many product categories to skip in the result. | ||
* - (query) limit=100 {integer} Limit the number of product categories returned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: expand
& fields
are missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one question
* - (query) parent_category_id {string} Returns categories scoped by parent | ||
* - (query) offset=0 {integer} How many product categories to skip in the result. | ||
* - (query) limit=100 {integer} Limit the number of product categories returned. | ||
* x-codeSamples: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: Should we add the react example or do you plan to update later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
react?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry i meant the js client usage
What:
Introduces a store endpoint to retrieve a list of product categories
Why:
This is part of a greater goal of allowing products to be added to multiple categories.
How:
RESOLVES CORE-968