Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(workflows): update product workflow #4982

Merged
merged 78 commits into from
Oct 19, 2023
Merged

feat(workflows): update product workflow #4982

merged 78 commits into from
Oct 19, 2023

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Sep 7, 2023 •
edited
Loading

What

  • added "update product" workflow

@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: c2e9fab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Oct 19, 2023 9:44am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Oct 19, 2023 9:44am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Oct 19, 2023 9:44am

@vercel vercel bot temporarily deployed to Preview – api-reference September 8, 2023 07:41 Inactive
@vercel vercel bot temporarily deployed to Preview – medusa-docs September 8, 2023 07:46 Inactive
@vercel vercel bot temporarily deployed to Preview – api-reference September 11, 2023 19:12 Inactive
@vercel vercel bot temporarily deployed to Preview – medusa-docs September 11, 2023 19:16 Inactive
@vercel vercel bot temporarily deployed to Preview – api-reference September 13, 2023 12:01 Inactive
@vercel vercel bot temporarily deployed to Preview – medusa-docs September 13, 2023 12:05 Inactive
@vercel vercel bot temporarily deployed to Preview – api-reference September 14, 2023 07:42 Inactive
@vercel vercel bot temporarily deployed to Preview – medusa-docs September 14, 2023 07:47 Inactive
@vercel vercel bot temporarily deployed to Preview – api-reference September 14, 2023 15:50 Inactive
@vercel vercel bot temporarily deployed to Preview – medusa-docs September 14, 2023 15:54 Inactive
@vercel vercel bot temporarily deployed to Preview – api-reference September 15, 2023 13:54 Inactive
@vercel vercel bot temporarily deployed to Preview – medusa-docs September 15, 2023 13:57 Inactive
@vercel vercel bot temporarily deployed to Preview – medusa-docs September 15, 2023 15:30 Inactive
@vercel vercel bot temporarily deployed to Preview – api-reference September 15, 2023 15:32 Inactive
@vercel vercel bot temporarily deployed to Preview – api-reference September 18, 2023 14:38 Inactive
@vercel vercel bot temporarily deployed to Preview – medusa-docs September 18, 2023 14:40 Inactive
@fPolic fPolic marked this pull request as ready for review September 18, 2023 19:10
@fPolic fPolic requested a review from a team as a code owner September 18, 2023 19:10
adrien2p
adrien2p requested changes Sep 25, 2023
View reviewed changes
integration-tests/factories/simple-product-factory.ts Outdated Show resolved Hide resolved
integration-tests/plugins/__tests__/product/admin/index.ts Outdated Show resolved Hide resolved
integration-tests/plugins/__tests__/product/admin/index.ts Outdated Show resolved Hide resolved
integration-tests/plugins/__tests__/product/admin/index.ts Outdated Show resolved Hide resolved
integration-tests/plugins/__tests__/product/admin/index.ts Show resolved Hide resolved
packages/workflows/src/handlers/middlewares/map-data.ts Outdated Show resolved Hide resolved
packages/workflows/src/handlers/middlewares/update-prodcut-reshape-sales-channes-data.ts Outdated Show resolved Hide resolved
packages/workflows/src/handlers/middlewares/update-products-extract-created-variants.ts Show resolved Hide resolved
packages/workflows/src/handlers/middlewares/use-variants-inventory-items.ts Show resolved Hide resolved
packages/workflows/src/handlers/product/update-products.ts Show resolved Hide resolved
fPolic and others added 16 commits October 2, 2023 09:28
@fPolic
Merge branch 'develop' into feat/update-product-workflow
1899184
@fPolic
fix: address comments
7344643
@fPolic
Merge branch 'develop' into feat/update-product-workflow
c8400f4
@fPolic
fix: revert handle
893b3e8
@fPolic
Merge branch 'develop' into feat/update-product-workflow
732f415
@fPolic
feat: generic map data util middleware
9f082de
@fPolic
Merge branch 'develop' into feat/update-product-workflow
fd996b8
@fPolic
chore: fix import / export
9c1ff8f
@fPolic
Merge branch 'develop' into feat/update-product-workflow
d124605
@fPolic
Merge branch 'develop' into feat/update-product-workflow
fe1eea7
@fPolic
Merge branch 'develop' into feat/update-product-workflow
8f0af8e 
# Conflicts:
#	packages/workflows/src/definition/product/create-products.ts
#	packages/workflows/src/handlers/inventory/attach-inventory-items.ts
#	packages/workflows/src/handlers/inventory/create-inventory-items.ts
#	packages/workflows/src/handlers/inventory/remove-inventory-items.ts
@fPolic
fix: merge conflicts
97eb69a
@fPolic
fix: new shape for inventory handlers
22f9dad
@fPolic
Merge branch 'develop' into feat/update-product-workflow
dd4db9d
@fPolic
fix: inventory middleware data shape
44e6283
@riqwan
Merge branch 'develop' into feat/update-product-workflow
352baf7
riqwan
riqwan approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a bit more work to be done on the revert step, but looks good otherwise.

integration-tests/factories/simple-product-factory.ts Outdated Show resolved Hide resolved
packages/inventory/src/services/inventory.ts Show resolved Hide resolved
packages/product/src/services/product-module-service.ts Outdated Show resolved Hide resolved
packages/workflows/src/handlers/inventory/restore-inventory-items.ts Show resolved Hide resolved
packages/workflows/src/handlers/product/revert-update-products.ts Show resolved Hide resolved
carlos-r-l-rodrigues
carlos-r-l-rodrigues approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
The only point missing is review the UNIQUE constraints now that it is using softDelete. It can be in another PR if they have to be changed.

adrien2p
adrien2p approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @riqwan @fPolic have the constraints been reviewed?

@fPolic
Copy link
Contributor Author

fPolic commented Oct 19, 2023 •
edited
Loading

LGTM, @riqwan @fPolic have the constraints been reviewed?

We should alter the unique constraint to include deleted_at but as Carlos suggested it can be done in a separate PR if it blocks merge now

@kodiakhq kodiakhq bot merged commit aba9ded into develop Oct 19, 2023
12 checks passed
@kodiakhq kodiakhq bot deleted the feat/update-product-workflow branch October 19, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riqwan riqwan riqwan approved these changes

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@adrien2p adrien2p adrien2p approved these changes

@olivermrbl olivermrbl Awaiting requested review from olivermrbl

Assignees
No one assigned
Labels
automerge proj: isolate-prod-mod
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fPolic @riqwan @adrien2p @carlos-r-l-rodrigues @olivermrbl