Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(medusa): integrate pricing module to core #5304

Merged
merged 52 commits into from
Oct 30, 2023

Conversation

pKorsholm
Copy link
Contributor

@pKorsholm pKorsholm commented Oct 6, 2023

What

  • integrate pricing module calculate read into pricing service to calculate prices when store endpoints are hit and the pricing module is enabled

@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2023

🦋 Changeset detected

Latest commit: 96663f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@medusajs/medusa Patch
@medusajs/types Patch
@medusajs/pricing Patch
@medusajs/medusa-oas-cli Patch
@medusajs/oas-github-ci Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2023 1:20pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2023 1:20pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2023 1:20pm

const queryContext: PriceSelectionContext = removeNullish(context)

if (queryContext.currency_code) {
queryContext.currency_code = queryContext.currency_code.toUpperCase()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion : i don't think it should be done jere but maybe the module should always upper case?

@adrien2p
Copy link
Member

adrien2p commented Oct 9, 2023

Oups sorry i havent seen the draft 😅

@pKorsholm
Copy link
Contributor Author

/snapshot-this

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

🚀 A snapshot release has been made for this PR

Test the snapshot by updating your package.json with the newly published version:

yarn add @medusajs/medusa@1.17.2-snapshot-20231009083226

Latest commit: 441844e

@pKorsholm pKorsholm marked this pull request as ready for review October 10, 2023 12:44
@pKorsholm pKorsholm requested a review from a team as a code owner October 10, 2023 12:44
@pKorsholm pKorsholm requested review from adrien2p and riqwan October 10, 2023 14:25
@riqwan
Copy link
Contributor

riqwan commented Oct 11, 2023

/snapshot-this

@github-actions
Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/link-modules@0.2.1-snapshot-20231011083659
yarn add @medusajs/medusa@1.17.2-snapshot-20231011083659
yarn add @medusajs/modules-sdk@1.12.1-snapshot-20231011083659
yarn add @medusajs/medusa-oas-cli@0.2.22-snapshot-20231011083659
yarn add @medusajs/pricing@0.1.1-snapshot-20231011083659
yarn add @medusajs/types@1.11.4-snapshot-20231011083659
yarn add @medusajs/utils@1.10.4-snapshot-20231011083659

Latest commit: 9c1c19f

@pKorsholm pKorsholm requested a review from olivermrbl October 11, 2023 16:17
packages/medusa/src/api/middlewares/error-handler.ts Outdated Show resolved Hide resolved
packages/medusa/src/commands/seed.ts Outdated Show resolved Hide resolved
integration-tests/plugins/medusa-config.js Outdated Show resolved Hide resolved
packages/medusa/src/services/pricing.ts Outdated Show resolved Hide resolved
packages/medusa/src/services/pricing.ts Outdated Show resolved Hide resolved
packages/medusa/src/services/pricing.ts Outdated Show resolved Hide resolved
packages/medusa/src/services/pricing.ts Outdated Show resolved Hide resolved
packages/medusa/src/services/pricing.ts Show resolved Hide resolved
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM – great work guys! 🚀

@olivermrbl
Copy link
Contributor

Just need a green pipeline :)

@olivermrbl olivermrbl changed the title Feat(medusa): integrate pricing module to reads from core feat(medusa): integrate pricing module to reads from core Oct 22, 2023
@pKorsholm pKorsholm changed the title feat(medusa): integrate pricing module to reads from core feat(medusa): integrate pricing module to core Oct 24, 2023
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

pKorsholm and others added 7 commits October 27, 2023 08:03
* initial

* loader update

* more progress on loaders

* update integration tests and remote-query loader

* remove helper

* migrate isolated modules

* fix test

* fix integration test

* update with pr feedback

* unregister medusa-app

* re-register medusaApp

* fix featureflag

* set timeout

* set timeout

* conditionally run link-module migrations

* pr feedback 1

* add driver options for db

* throw if link is not defined in migration script

* pass config module directly

* include container in migrate command
@pKorsholm pKorsholm force-pushed the feat/read-prices-from-pricing-module branch from 269a1c8 to d3a20db Compare October 27, 2023 06:03
@riqwan riqwan merged commit 148f537 into develop Oct 30, 2023
12 checks passed
@riqwan riqwan deleted the feat/read-prices-from-pricing-module branch October 30, 2023 13:42
This was referenced Oct 30, 2023
@riqwan riqwan restored the feat/read-prices-from-pricing-module branch October 31, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants