-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(medusa): integrate pricing module to core #5304
Conversation
🦋 Changeset detectedLatest commit: 96663f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
const queryContext: PriceSelectionContext = removeNullish(context) | ||
|
||
if (queryContext.currency_code) { | ||
queryContext.currency_code = queryContext.currency_code.toUpperCase() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion : i don't think it should be done jere but maybe the module should always upper case?
packages/medusa/src/utils/get-product-pricing-with-pricing-module.ts
Outdated
Show resolved
Hide resolved
packages/medusa/src/utils/get-product-pricing-with-pricing-module.ts
Outdated
Show resolved
Hide resolved
packages/medusa/src/utils/get-product-pricing-with-pricing-module.ts
Outdated
Show resolved
Hide resolved
packages/medusa/src/utils/get-product-pricing-with-pricing-module.ts
Outdated
Show resolved
Hide resolved
packages/medusa/src/utils/get-product-pricing-with-pricing-module.ts
Outdated
Show resolved
Hide resolved
packages/medusa/src/utils/get-product-pricing-with-pricing-module.ts
Outdated
Show resolved
Hide resolved
Oups sorry i havent seen the draft 😅 |
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshot by updating your yarn add @medusajs/medusa@1.17.2-snapshot-20231009083226
|
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/link-modules@0.2.1-snapshot-20231011083659 yarn add @medusajs/medusa@1.17.2-snapshot-20231011083659 yarn add @medusajs/modules-sdk@1.12.1-snapshot-20231011083659 yarn add @medusajs/medusa-oas-cli@0.2.22-snapshot-20231011083659 yarn add @medusajs/pricing@0.1.1-snapshot-20231011083659 yarn add @medusajs/types@1.11.4-snapshot-20231011083659 yarn add @medusajs/utils@1.10.4-snapshot-20231011083659
|
packages/link-modules/src/definitions/product-variant-price-set.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM – great work guys! 🚀
Just need a green pipeline :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
...es/medusa/src/migrations/1697103018534-drop_shipping_profile_profile_id_product_id_unique.ts
Outdated
Show resolved
Hide resolved
* initial * loader update * more progress on loaders * update integration tests and remote-query loader * remove helper * migrate isolated modules * fix test * fix integration test * update with pr feedback * unregister medusa-app * re-register medusaApp * fix featureflag * set timeout * set timeout * conditionally run link-module migrations * pr feedback 1 * add driver options for db * throw if link is not defined in migration script * pass config module directly * include container in migrate command
269a1c8
to
d3a20db
Compare
What