fix(admin-ui): Enhanced 'activity-drawer' visibility with z-index adjustment #5315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request focuses on improving the visibility of the 'activity-drawer' component by applying a z-index of 1 (z-1). The z-index ensures that the 'activity-drawer' consistently appears above other page elements, enhancing its prominence and ensuring a better user experience.
🦋 Changeset detectedLatest commit: 4e03ab9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@ram-you is attempting to deploy a commit to the medusajs Team on Vercel. A member of the Team first needs to authorize it. |
kasperkristensen
requested changes
Oct 26, 2023
There was a problem hiding this comment.
Hi @ram-you
Thanks for the PR!
z-1 is not a valid Tailwind class name, it goes from z-0 - z-100 in increments of 10. Alternatively, you could use an arbitrary value of z-[1].
packages/admin-ui/ui/src/components/organisms/activity-drawer/index.tsx
Outdated
Show resolved
Hide resolved
Change non existing 'z-1' to arbitrary value 'z-[1]'
kasperkristensen
approved these changes
Oct 27, 2023
olivermrbl
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
olivermrbl
approved these changes
Oct 30, 2023
This was referenced Oct 31, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving the visibility of the 'activity-drawer' component by applying a z-index of 1 (z-1). The z-index ensures that the 'activity-drawer' consistently appears above other page elements, enhancing its prominence and ensuring a better user experience.