fix(admin-ui): TIP in shipping option creation #5356
Conversation
🦋 Changeset detectedLatest commit: 11ce9e8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
|
@kasperkristensen – any chance you could find time to give this a review? |
There was a problem hiding this comment.
LGTM, just have one question.
Since the payload for creating a shipping option accepts includes_tax was the original intent that you were supposed to make the decision on a per option basis? IMO it makes perfect sense to base it on setting of the region, but I am not sure if there was some bigger idea behind allowing setting it per option and in that case maybe we should include a toggle in the UI.
|
@olivermrbl when is this going to be merged? |
I don't think we've discussed this flow, but it is a good point. For now, I'll merge this PR to fix the bug and add an issue for potentially adding in the toggle in the shipping options overview. Is that OK with you? One thing I do remember is that we discussed moving all TIP-related configurations to the Tax settings in admin for centralization purposes. So if we choose to add a toggle, we should also consider revisiting the Tax settings UI to include it as part of creating a shipping option override. |
Closes #5343