Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(medusa): Add item and shipping tax totals to order #5385

Merged

Conversation

pepijn-vanvlaanderen
Copy link
Contributor

At the moment the shipping tax total and item tax total are not available after fetching the order.

@pepijn-vanvlaanderen pepijn-vanvlaanderen requested a review from a team as a code owner October 17, 2023 09:40
@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2023

🦋 Changeset detected

Latest commit: 7cc4f7d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/medusa Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 17, 2023

@pepijn-vanvlaanderen is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@olivermrbl
Copy link
Contributor

@pepijn-vanvlaanderen – a couple of tests - both unit and integration - need to be updated before we merge :)

@olivermrbl olivermrbl changed the title Feature/item and shipping tax totals feat(medusa): Add item and shipping tax totals to order Oct 17, 2023
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Oct 19, 2023 7:57am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Oct 19, 2023 7:57am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Oct 19, 2023 7:57am

@olivermrbl olivermrbl merged commit 0d7c554 into medusajs:develop Oct 19, 2023
10 of 12 checks passed
@github-actions github-actions bot mentioned this pull request Oct 19, 2023
@pepijn-vanvlaanderen pepijn-vanvlaanderen deleted the feature/item-and-shipping-tax-totals branch October 19, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants