Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin-ui): Remove t() on product.status update #5394

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

olivermrbl
Copy link
Contributor

@olivermrbl olivermrbl commented Oct 17, 2023

Closes #5388

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2023

🦋 Changeset detected

Latest commit: 69f737f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@medusajs/medusa Patch
@medusajs/admin-ui Patch
@medusajs/admin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2023 7:44am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2023 7:44am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2023 7:44am

@olivermrbl olivermrbl marked this pull request as ready for review October 17, 2023 14:50
@olivermrbl olivermrbl requested a review from a team as a code owner October 17, 2023 14:50
@olivermrbl olivermrbl force-pushed the fix/product-status-update branch 3 times, most recently from d0354a5 to c29109c Compare October 18, 2023 06:49
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ahah the translation was applied on the property to update nice catch

@olivermrbl
Copy link
Contributor Author

/snapshot-this

Copy link
Contributor

@fPolic fPolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olivermrbl
Copy link
Contributor Author

/snapshot-this

@olivermrbl olivermrbl merged commit a0963f0 into develop Oct 18, 2023
12 checks passed
@github-actions github-actions bot mentioned this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin : translated status causes product publishing errors for non-english
3 participants