Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(medusa-js): JwtTokenManager.registerJwt for store domain #5406

Merged
merged 3 commits into from
Oct 18, 2023
Merged

fix(medusa-js): JwtTokenManager.registerJwt for store domain #5406

merged 3 commits into from
Oct 18, 2023

Conversation

dPreininger
Copy link
Contributor

Fixes #5342. Special thanks to @CervarlCG for spotting the issue and finding the fix.

@dPreininger dPreininger requested a review from a team as a code owner October 18, 2023 09:07
@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2023

🦋 Changeset detected

Latest commit: cf6d367

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/medusa-js Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 18, 2023

@dPreininger is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@dPreininger dPreininger changed the title Fix(medusa-js): Fix JwtTokenManager.register for store domain Fix(medusa-js): Fix JwtTokenManager.registerJwt for store domain Oct 18, 2023
@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2023 9:38am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2023 9:38am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2023 9:38am

@olivermrbl olivermrbl changed the title Fix(medusa-js): Fix JwtTokenManager.registerJwt for store domain fix(medusa-js): JwtTokenManager.registerJwt for store domain Oct 18, 2023
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @dPreininger!

@olivermrbl olivermrbl merged commit 98e2755 into medusajs:develop Oct 18, 2023
@github-actions github-actions bot mentioned this pull request Oct 18, 2023
@dPreininger dPreininger deleted the fix/medusa-js-token-manager-for-store branch October 19, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read properties of undefined (reading 'access_token')
2 participants