Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(medusa, link-modules): sales channel <> product module link #5450

Merged
merged 67 commits into from
Dec 15, 2023
Merged

feat(medusa, link-modules): sales channel <> product module link #5450

merged 67 commits into from
Dec 15, 2023

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Oct 23, 2023 •
edited
Loading

What

  • add link for product module <> sales channel service
  • add migrations for the pivot table
  • add list method to the sales channel service

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 7a83b51

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@medusajs/link-modules Patch
@medusajs/medusa Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Dec 15, 2023 10:25am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Dec 15, 2023 10:25am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Dec 15, 2023 10:25am

@fPolic fPolic changed the title feat: sales channel <> product module joiner config feat(medusa, link-module): sales channel <> product module joiner config Oct 23, 2023
@fPolic fPolic marked this pull request as ready for review October 23, 2023 13:02
@fPolic fPolic requested a review from a team as a code owner October 23, 2023 13:02
adrien2p
adrien2p approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrien2p
Copy link
Member

Have you checked if any other constraints was link to the sales channel etc?

@olivermrbl
Copy link
Contributor

Have you checked if any other constraints was link to the sales channel etc?

Perhaps Publishable API keys?

@fPolic
Copy link
Contributor Author

fPolic commented Oct 23, 2023

Have you checked if any other constraints was link to the sales channel etc?

There are the following relations (if that is what you meant):

  1. SalesChannel <> Cart
  2. SalesChannel <> Order
  3. SalesChannel <> Store
  4. SalesChannel <> PublishableApiKey
  5. SalesChannel <> SalesChannelLocation

I was planning on covering each domain in a separate PR for easier reviewing.

@olivermrbl
Copy link
Contributor

@fPolic, can I get you to add a changeset before we merge?

@olivermrbl
Copy link
Contributor

/snapshot-this

@github-actions
Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/admin@7.1.5-snapshot-20231024062306
yarn add @medusajs/admin-ui@2.1.5-snapshot-20231024062306
yarn add create-medusa-app@1.2.3-snapshot-20231024062306
yarn add @medusajs/inventory@1.11.1-snapshot-20231024062306
yarn add @medusajs/link-modules@0.2.1-snapshot-20231024062306
yarn add @medusajs/medusa@1.17.2-snapshot-20231024062306
yarn add medusa-file-s3@1.4.0-snapshot-20231024062306
yarn add @medusajs/medusa-js@6.1.2-snapshot-20231024062306
yarn add medusa-plugin-brightpearl@1.3.12-snapshot-20231024062306
yarn add @medusajs/modules-sdk@1.12.1-snapshot-20231024062306
yarn add @medusajs/medusa-oas-cli@0.2.22-snapshot-20231024062306
yarn add @medusajs/orchestration@0.4.2-snapshot-20231024062306
yarn add @medusajs/pricing@0.1.1-snapshot-20231024062306
yarn add @medusajs/product@0.3.1-snapshot-20231024062306
yarn add @medusajs/types@1.11.4-snapshot-20231024062306
yarn add @medusajs/utils@1.10.4-snapshot-20231024062306
yarn add @medusajs/workflows@0.2.4-snapshot-20231024062306

Latest commit: 5c77029

@fPolic fPolic changed the base branch from feat/sales-channel-module to develop October 24, 2023 08:31
@fPolic fPolic requested a review from olivermrbl October 25, 2023 11:48
adrien2p
adrien2p approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we will need to take care to include that into the core right? if the ff is enabled, then when we list the product they must take into account the sales channel. same if the product is isolated? cc @olivermrbl should we create tickets in linear to not forget what needs to be done after

@olivermrbl
Copy link
Contributor

@adrien2p I just spoke with @fPolic about this. We will tackle this before moving ahead with other joiner configs. But yes, creating tickets for the things we identify to need fixing, is a great idea

@fPolic fPolic requested a review from olivermrbl November 20, 2023 11:43
@fPolic fPolic changed the title feat(medusa, link-module): sales channel <> product module link feat(medusa, link-modules): sales channel <> product module link Dec 6, 2023
This was referenced Dec 6, 2023
Merged
Merged
@olivermrbl
Copy link
Contributor

LGTM, let's merge when 1.19 is out. Will release mid-week

@olivermrbl
Copy link
Contributor

@fPolic, can I get you to resolve conflicts, so we can merge?

fPolic and others added 3 commits December 15, 2023 10:58
@fPolic
Merge branch 'develop' into feat/sales-channel-module--joiner-config
fb8389b 
# Conflicts:
#	packages/medusa/src/api/routes/admin/products/get-product.ts
#	packages/medusa/src/api/routes/admin/products/list-products.ts
@fPolic
fix: add sc to filter to list
87fa07b
@fPolic
Merge branch 'develop' into feat/sales-channel-module--joiner-config
7a83b51
@olivermrbl olivermrbl merged commit 1d7888a into develop Dec 15, 2023
15 checks passed
@olivermrbl olivermrbl deleted the feat/sales-channel-module--joiner-config branch December 15, 2023 12:43
This was referenced Dec 15, 2023
Merged
Open
Open
Open
This was referenced Dec 23, 2023
Open
Open
@github-actions github-actions bot mentioned this pull request Jan 1, 2024
Open
@github-actions github-actions bot mentioned this pull request Jan 9, 2024
Open
@github-actions github-actions bot mentioned this pull request Mar 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@riqwan riqwan riqwan approved these changes

@adrien2p adrien2p Awaiting requested review from adrien2p

@olivermrbl olivermrbl Awaiting requested review from olivermrbl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fPolic @adrien2p @olivermrbl @riqwan @carlos-r-l-rodrigues