fix(medusa, modules-sdk, modules): Module loading missing dependencies + remote query reference issue #5468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ected dependencies and remote query reference fix
🦋 Changeset detectedLatest commit: 3605a18 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
adrien2p
requested review from
carlos-r-l-rodrigues,
olivermrbl and
pKorsholm
adrien2p
changed the title
…js/medusa into fix/medusa-app-lading-deps-issues
|
/snapshot-this |
|
Before merging I d like to run some tests with the snapshot |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/admin-ui@2.1.6-snapshot-20231025100647yarn add @medusajs/cache-inmemory@1.8.9-snapshot-20231025100647yarn add @medusajs/cache-redis@1.8.9-snapshot-20231025100647yarn add @medusajs/event-bus-local@1.9.7-snapshot-20231025100647yarn add @medusajs/event-bus-redis@1.8.10-snapshot-20231025100647yarn add @medusajs/inventory@1.11.2-snapshot-20231025100647yarn add @medusajs/link-modules@0.2.2-snapshot-20231025100647yarn add @medusajs/medusa@1.17.3-snapshot-20231025100647yarn add @medusajs/modules-sdk@1.12.2-snapshot-20231025100647yarn add @medusajs/orchestration@0.4.3-snapshot-20231025100647yarn add @medusajs/pricing@0.1.2-snapshot-20231025100647yarn add @medusajs/product@0.3.2-snapshot-20231025100647yarn add @medusajs/stock-location@1.11.1-snapshot-20231025100647
|
|
@olivermrbl can we merge this? |
|
Fine by me, but I don't know if this leads to conflicts with other Pricing Module related PRs. Have you coordinated with the guys? |
riqwan
approved these changes
Oct 26, 2023
adrien2p
force-pushed
the
fix/medusa-app-lading-deps-issues
branch
from
b096249 to
fe4e250
Compare
|
LGTM, should we merge? |
This was referenced Oct 26, 2023
Merged
This was referenced Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
At the moment, the modules are expecting some dependencies such as the event bus module, but they fail silently since it is not a required deps. On the other hand, if the deps is required then it create some issues since the dep is missing. Also, the remote query was mutating the reference of an array object and leading to unexpected side effects.
This pr aims to resolve the dependency issues for the modules as well as the remote query reference mutation issue.
I ve moved this to a separate pr to not hold on it in the search module pr