fix(medusa): admin get product should return prices when expected #5480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4c1ec5b The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
olivermrbl
previously approved these changes
Oct 26, 2023
olivermrbl
force-pushed
the
fix/admin-get-product
branch
from
e99628a to
93573af
Compare
olivermrbl
force-pushed
the
fix/admin-get-product
branch
from
93573af to
639ae66
Compare
adrien2p
commented
Oct 27, 2023
…to fix/admin-get-product
adrien2p
commented
Oct 29, 2023
|
@adrien2p, will you resolve the conflicts? Then I think we should be good to go |
|
Our integration test suites are getting more and more flaky. Think we need to dedicate some time to improving it soon |
|
@adrien2p, what do you think - should we merge this badboy? |
olivermrbl
approved these changes
Oct 31, 2023
|
Yes i think so 👌 |
olivermrbl
reviewed
Oct 31, 2023
| @@ -35,6 +36,7 @@ export const useAdminProducts = ( | |||
|
|
|||
| export const useAdminProduct = ( | |||
There was a problem hiding this comment.
note to self: "breaking"
This was referenced Oct 31, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.