Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin-ui): modify webpack config to prevent throwing sourcemap errors #5484

Merged
merged 4 commits into from
Oct 30, 2023

Conversation

kasperkristensen
Copy link
Contributor

@kasperkristensen kasperkristensen commented Oct 27, 2023

What

  • A error started popping up in our CI, and has been reported by users in our Discord, that the admin would fail to build. The error seemed to stem from ´source-map-loader´ failing to process prism-react-renderer.
  • This PR removes the loader, this may cause browsers to not be able to interpret source maps from some third party libraries.

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2023

🦋 Changeset detected

Latest commit: d28ef7a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/admin-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2023 8:51am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2023 8:51am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2023 8:51am

@kasperkristensen kasperkristensen changed the title fix: modify webpack config to prevent throwing unnessecery errors fix: modify webpack config to prevent throwing unnecessary errors Oct 27, 2023
@kasperkristensen kasperkristensen changed the title fix: modify webpack config to prevent throwing unnecessary errors fix: modify webpack config to prevent throwing sourcemap errors Oct 27, 2023
@kasperkristensen kasperkristensen marked this pull request as ready for review October 27, 2023 15:55
@kasperkristensen kasperkristensen requested a review from a team as a code owner October 27, 2023 15:55
@kasperkristensen kasperkristensen changed the title fix: modify webpack config to prevent throwing sourcemap errors fix(admin-ui): modify webpack config to prevent throwing sourcemap errors Oct 30, 2023
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

this may cause browsers to not be able to interpret source maps from some third party libraries.

Do you think we should include this in the release notes as a breaking change?

@olivermrbl olivermrbl merged commit b69f182 into develop Oct 30, 2023
12 checks passed
@github-actions github-actions bot mentioned this pull request Oct 30, 2023
@kasperkristensen
Copy link
Contributor Author

@olivermrbl Not a breaking change, but might be worth to include a note, as it makes it harder to debug third party dependencies. Needing to debug npm packages should be an edge case, but sometimes necessary and in that case this makes that process harder, as you will be left with debugging the compiled code.

@kasperkristensen kasperkristensen deleted the fix/admin-webpack-config branch November 2, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants