-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(admin-ui): modify webpack config to prevent throwing sourcemap errors #5484
Conversation
🦋 Changeset detectedLatest commit: d28ef7a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
this may cause browsers to not be able to interpret source maps from some third party libraries.
Do you think we should include this in the release notes as a breaking change?
@olivermrbl Not a breaking change, but might be worth to include a note, as it makes it harder to debug third party dependencies. Needing to debug npm packages should be an edge case, but sometimes necessary and in that case this makes that process harder, as you will be left with debugging the compiled code. |
What
prism-react-renderer
.