Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin-ui): Make regions in tax setting scrollable #5530

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

kasperkristensen
Copy link
Contributor

@kasperkristensen kasperkristensen commented Nov 2, 2023

What

  • Fixes an issue where the region overview in tax settings was not scrollable.
  • The previous implementation only loaded the first 20 regions. This has been fixed by adding a IntersectionObserver that loads the next 20 regions when the last option is scrolled into view, if there are more regions to fetch.

CLOSES CORE-1530

Copy link

changeset-bot bot commented Nov 2, 2023

🦋 Changeset detected

Latest commit: 042de06

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/admin-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2023 10:32am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2023 10:32am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2023 10:32am

@kasperkristensen kasperkristensen marked this pull request as ready for review November 2, 2023 10:32
@kasperkristensen kasperkristensen requested a review from a team as a code owner November 2, 2023 10:32
@kasperkristensen kasperkristensen linked an issue Nov 2, 2023 that may be closed by this pull request
@olivermrbl
Copy link
Contributor

/snapshot-this

Copy link
Contributor

github-actions bot commented Nov 2, 2023

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/admin-ui@2.1.7-snapshot-20231102114406
yarn add @medusajs/cache-inmemory@1.8.10-snapshot-20231102114406
yarn add @medusajs/cache-redis@2.0.0-snapshot-20231102114406

Latest commit: 3a34496

@olivermrbl olivermrbl merged commit 8e48be5 into develop Nov 2, 2023
12 checks passed
@olivermrbl olivermrbl deleted the fix/tax-region-overflow branch November 2, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot scroll in tax rates columns
2 participants