Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin-ui): Prevent oversized product request in Price List domain #5535

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

kasperkristensen
Copy link
Contributor

What

  • Fixes an issue were on initial load of the Price List pages a request would fire fetching products with a limit of 0. This PR prevents that request from being fired.

Note

  • Firing a request with a limit of 0 resulting in every entity getting returned seems like a underlying bug in how our list params are getting generated. I am guessing that there is a check somewhere for if (limit) { ... causing the DB query to get fired with no take param, which results in every entity getting returned.

@kasperkristensen kasperkristensen requested a review from a team as a code owner November 2, 2023 13:13
Copy link

changeset-bot bot commented Nov 2, 2023

🦋 Changeset detected

Latest commit: edadb9b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/admin-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview Nov 2, 2023 1:13pm
docs-ui 🔄 Building (Inspect) Visit Preview Nov 2, 2023 1:13pm
medusa-docs 🔄 Building (Inspect) Visit Preview Nov 2, 2023 1:13pm

@olivermrbl
Copy link
Contributor

/snapshot-this

Copy link
Contributor

github-actions bot commented Nov 2, 2023

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/admin-ui@2.1.7-snapshot-20231102151935
yarn add @medusajs/cache-inmemory@1.8.10-snapshot-20231102151935
yarn add @medusajs/cache-redis@2.0.0-snapshot-20231102151935

Latest commit: 3bf9d8d

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@olivermrbl olivermrbl merged commit f7e9829 into develop Nov 2, 2023
12 checks passed
@olivermrbl olivermrbl deleted the fix/pricing-domain-oversized-request branch November 2, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Editing Pricelists after latest medusa update (core & admin)
2 participants