feat(utils): Introduce promiseAll util

[adrien2p]

What
Promise.all with typeorm transaction does not play well in case of nesetd promises. A rejection does not necessarely rollback all queries since the nested promises will run on an orphan transaction resulting in them being commited. This utils aim to replace all promise.all usage

[changeset-bot]

🦋 Changeset detected

Latest commit: de32729

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

Name	Type
@medusajs/medusa	Patch
@medusajs/inventory	Patch
medusa-fulfillment-webshipper	Patch
medusa-plugin-brightpearl	Patch
medusa-plugin-contentful	Patch
medusa-source-shopify	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
api-reference	⬜️ Ignored (Inspect)	Visit Preview		Nov 6, 2023 6:39pm
docs-ui	⬜️ Ignored (Inspect)	Visit Preview		Nov 6, 2023 6:39pm
medusa-docs	⬜️ Ignored (Inspect)	Visit Preview		Nov 6, 2023 6:39pm

[adrien2p]

@olivermrbl @carlos-r-l-rodrigues what do you think about it?

[adrien2p]

I ve done an example with the order service, let see the tests

[adrien2p]

If we agree on the approach, then we can start fixing all the places

[carlos-r-l-rodrigues]

LGTM

[adrien2p]

should we update all places if everybody aggree?

[adrien2p]

ps: I haven't changes everywhere if I thought it wasnt making too much sense

[adrien2p]

@olivermrbl I had to add the utils package as a dep in some plugins. Don't think it should be a problem for those. Though, I ve used the workspace:^ for the version. Let me know if you want me to change it

[olivermrbl]

Perhaps, we should add a note on this in our troubleshooting section. Although, not directly related to Medusa, it would be good to be able to point somewhere in case developers experience similar issues working with our services.

cc @shahednasser

[shahednasser]

Sure @olivermrbl , is there a bit more context to the exact problem or error that occurs (which makes it easier for people to find) and the proposed solution?

[olivermrbl]

Aside from the original issue, this Typeorm issue and this SO submission do a good job of explaining the issue succinctly. I don't think we need to go into depth about how promise.All works, so maybe just highlight that if you are experiencing issues rolling back DB transactions when running multiple promises with promise.All, this might be why.

[shahednasser]

Sure, but a troubleshooting guide should provide some direction for a solution, could be just an alternative of using Promise.all. Do we have some kind of advice to provide people running into then issue?

[olivermrbl]

Do we have some kind of advice to provide people running into then issue?

My bad, I should have mentioned this previously. We should recommend the util function introduced in this PR promiseAll from @medusajs/utils