chore(types): Add TSDoc comments to IInventoryService #5630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
shahednasser
commented
Nov 14, 2023
shahednasser
commented
- Add TSDoc comments to the IInventoryService so that we can generate a reference later for the inventory module.
- Small fixes to the product module's TSDocs.
🦋 Changeset detectedLatest commit: 593f5fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
pKorsholm
approved these changes
Nov 15, 2023
Comment on lines
+371
to
+372
| * @prop inventory_item_id - The ID of the associated inventory level. | ||
| * @prop location_id - The ID of the associated location. |
There was a problem hiding this comment.
question: should we include stocked_quantity and incoming_quantity in this?
There was a problem hiding this comment.
It includes the TSDoc comments for them defined in UpdateInventoryLevelInput by default.
This was referenced Nov 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.