fix(product, types, workflows): Update product variant workflow #5668

pKorsholm · 2023-11-21T12:26:45Z

What

Fix issues with update-variant workflow:
- other variants than the updated variant are no longer removed
- options are updated properly

changeset-bot · 2023-11-21T12:26:49Z

🦋 Changeset detected

Latest commit: d81acff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

Name	Type
@medusajs/workflows	Patch
@medusajs/product	Patch
@medusajs/types	Patch
@medusajs/pricing	Patch
@medusajs/medusa	Patch
@medusajs/utils	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2023-11-21T12:26:53Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments

Name	Status	Preview	Updated (UTC)
api-reference	⬜️ Ignored (Inspect)	Visit Preview	Nov 23, 2023 2:24pm
docs-ui	⬜️ Ignored (Inspect)	Visit Preview	Nov 23, 2023 2:24pm
medusa-docs	⬜️ Ignored (Inspect)	Visit Preview	Nov 23, 2023 2:24pm

pKorsholm · 2023-11-21T13:26:54Z

packages/types/src/product/service.ts

@@ -1489,87 +1490,92 @@ export interface IProductModuleService {
    sharedContext?: Context
  ): Promise<ProductVariantDTO[]>

+  updateVariants(


Change is here

pKorsholm · 2023-11-21T13:49:23Z

packages/types/src/product/common.ts

   * @expandable
   */
-  options: ProductOptionValueDTO
+  options: ProductOptionValueDTO[]


here's the change

riqwan

CLEAN!

integration-tests/plugins/__tests__/product/admin/update-product-variant.spec.ts

packages/product/src/repositories/product-option-value.ts

packages/product/src/services/product-module-service.ts

Co-authored-by: Riqwan Thamir <rmthamir@gmail.com>

…ct-variant.spec.ts Co-authored-by: Riqwan Thamir <rmthamir@gmail.com>

integration-tests/plugins/__tests__/product/admin/update-product-variant.spec.ts

packages/product/src/repositories/product-option-value.ts

packages/product/src/services/product-module-service.ts

packages/workflows/src/handlers/product/update-product-variants.ts

pKorsholm · 2023-11-21T17:56:50Z

/snapshot-this

riqwan · 2023-11-21T18:29:48Z

/snapshot-this

pKorsholm · 2023-11-22T09:26:42Z

/snapshot-this

github-actions · 2023-11-22T09:32:32Z

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/medusa@1.18.1-snapshot-20231122093138

yarn add @medusajs/product@0.3.5-snapshot-20231122093138

yarn add @medusajs/types@1.11.8-snapshot-20231122093138

yarn add @medusajs/utils@1.11.1-snapshot-20231122093138

yarn add @medusajs/workflows@0.3.1-snapshot-20231122093138

Latest commit: dc5750d

adrien2p · 2023-11-23T09:32:12Z

.changeset/young-items-drop.md

@@ -1,9 +1,10 @@
 ---
 "@medusajs/workflows": patch
 "@medusajs/product": patch
+"@medusajs/pricing": patch


todo: There is two changeset, the first one seams targetting the right package, but not this one

pricing was missing in the core integration changeset from the pr we merged earlier, just adding it here

adrien2p · 2023-11-23T09:32:31Z

.github/workflows/action.yml

@@ -125,7 +125,6 @@ jobs:
        env:
          DB_PASSWORD: postgres
          DB_USERNAME: postgres


question: Why is this deleted?

as discussed split-tests doesn't exist as a step anywhere

integration-tests/plugins/__tests__/product/admin/update-product-variant.spec.ts

packages/product/src/repositories/product-option-value.ts

pKorsholm added 2 commits November 21, 2023 11:33

add product option value service + repo

c200a01

upsert options where possible

b9a1956

pKorsholm added 5 commits November 21, 2023 13:08

remove method not related to pr

72cf434

update integration tests

9cff152

rename variable

fbde7b6

add injectTransactionManager

aec91a0

flavor update

3c4ab61

pKorsholm commented Nov 21, 2023

View reviewed changes

pKorsholm added 3 commits November 21, 2023 13:28

rm tsdocs for internal interface

88a61de

cleanup

7f6316f

refactor product-module service method

5ad5f46

pKorsholm commented Nov 21, 2023

View reviewed changes

pKorsholm added 4 commits November 21, 2023 13:52

remove promiseAll

abef992

add changeset

ba70cd2

add integration test for multiple updates

cc2336f

rename test

49493e8

pKorsholm marked this pull request as ready for review November 21, 2023 14:12

pKorsholm requested a review from a team as a code owner November 21, 2023 14:12

Merge branch 'develop' into fix/update-product-variant-workflow

b08466e

pKorsholm changed the title ~~Fix/update product variant workflow~~ fix(product, types, workflows): Update product variant workflow Nov 21, 2023

cleanup cast

481ff3c

riqwan approved these changes Nov 21, 2023

View reviewed changes

pKorsholm and others added 6 commits November 21, 2023 14:26

Update packages/product/src/repositories/product-option-value.ts

4ab10f1

Co-authored-by: Riqwan Thamir <rmthamir@gmail.com>

update option.id

ac9fe09

rename result variable

26acb31

Update packages/product/src/services/product-module-service.ts

03629bd

Co-authored-by: Riqwan Thamir <rmthamir@gmail.com>

Update integration-tests/plugins/__tests__/product/admin/update-produ…

edc309e

…ct-variant.spec.ts Co-authored-by: Riqwan Thamir <rmthamir@gmail.com>

redo test check

826dc42

use serialize

9e95e84

pKorsholm requested review from olivermrbl and adrien2p November 21, 2023 14:54

adrien2p reviewed Nov 21, 2023

View reviewed changes

pKorsholm added 2 commits November 21, 2023 16:01

fix pr feedback

657b27d

use util for arrayDifference

776b805

pKorsholm requested a review from adrien2p November 21, 2023 16:17

Merge branch 'develop' into fix/update-product-variant-workflow

28d4d7e

add metadata test

cc67b58

pKorsholm and others added 3 commits November 22, 2023 09:41

fix pipeline?

2a5f6ce

chore: update changeset

6a0570c

Merge branch 'develop' into fix/update-product-variant-workflow

f667f84

adrien2p approved these changes Nov 23, 2023

View reviewed changes

pKorsholm and others added 2 commits November 23, 2023 13:43

pr feedback

34eb346

Merge branch 'develop' into fix/update-product-variant-workflow

d81acff

riqwan added the automerge label Nov 23, 2023

kodiakhq bot merged commit a39ce12 into develop Nov 23, 2023
12 checks passed

kodiakhq bot deleted the fix/update-product-variant-workflow branch November 23, 2023 14:35

This was referenced Nov 23, 2023

Version Packages #5673

Merged

Version Packages startcatalog/medusa#3

Open

Version Packages SGFGOV/medusa#3

Open

Version Packages weMoveOn/moveshop-commerce-core#2

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(product, types, workflows): Update product variant workflow #5668

fix(product, types, workflows): Update product variant workflow #5668

pKorsholm commented Nov 21, 2023 •

edited

Loading

changeset-bot bot commented Nov 21, 2023 •

edited

Loading

vercel bot commented Nov 21, 2023 •

edited

Loading

pKorsholm Nov 21, 2023 •

edited

Loading

pKorsholm Nov 21, 2023

riqwan left a comment

pKorsholm commented Nov 21, 2023

riqwan commented Nov 21, 2023

pKorsholm commented Nov 22, 2023

github-actions bot commented Nov 22, 2023

adrien2p Nov 23, 2023

pKorsholm Nov 23, 2023

adrien2p Nov 23, 2023

pKorsholm Nov 23, 2023

fix(product, types, workflows): Update product variant workflow #5668

fix(product, types, workflows): Update product variant workflow #5668

Conversation

pKorsholm commented Nov 21, 2023 • edited Loading

changeset-bot bot commented Nov 21, 2023 • edited Loading

🦋 Changeset detected

vercel bot commented Nov 21, 2023 • edited Loading

pKorsholm Nov 21, 2023 • edited Loading

Choose a reason for hiding this comment

pKorsholm Nov 21, 2023

Choose a reason for hiding this comment

riqwan left a comment

Choose a reason for hiding this comment

pKorsholm commented Nov 21, 2023

riqwan commented Nov 21, 2023

pKorsholm commented Nov 22, 2023

github-actions bot commented Nov 22, 2023

🚀 A snapshot release has been made for this PR

adrien2p Nov 23, 2023

Choose a reason for hiding this comment

pKorsholm Nov 23, 2023

Choose a reason for hiding this comment

adrien2p Nov 23, 2023

Choose a reason for hiding this comment

pKorsholm Nov 23, 2023

Choose a reason for hiding this comment

pKorsholm commented Nov 21, 2023 •

edited

Loading

changeset-bot bot commented Nov 21, 2023 •

edited

Loading

vercel bot commented Nov 21, 2023 •

edited

Loading

pKorsholm Nov 21, 2023 •

edited

Loading