feat(medusa): Improve add line item to cart perf and transaction management + clustering start command #5701

adrien2p · 2023-11-23T10:26:13Z

What

Improve the transaction management form add to cart end point
add a new cluster command to start the server. By default, it will consume all available cpus to start the medusa instances. An option is available to specify the number of CPU to use

changeset-bot · 2023-11-23T10:26:17Z

🦋 Changeset detected

Latest commit: 304c3ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@medusajs/medusa	Patch
@medusajs/medusa-cli	Patch
@medusajs/admin-ui	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2023-11-23T10:26:20Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments

Name	Status	Preview	Updated (UTC)
api-reference	⬜️ Ignored (Inspect)	Visit Preview	Dec 4, 2023 9:22am
docs-ui	⬜️ Ignored (Inspect)	Visit Preview	Dec 4, 2023 9:22am
medusa-docs	⬜️ Ignored (Inspect)	Visit Preview	Dec 4, 2023 9:22am

adrien2p · 2023-11-23T10:26:21Z

/snapshot-this

github-actions · 2023-11-23T10:32:02Z

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/link-modules@0.2.4-snapshot-20231123103111

yarn add @medusajs/medusa@1.18.1-snapshot-20231123103111

yarn add @medusajs/modules-sdk@1.12.4-snapshot-20231123103111

yarn add @medusajs/orchestration@0.5.0-snapshot-20231123103111

yarn add @medusajs/pricing@0.1.5-snapshot-20231123103111

yarn add @medusajs/product@0.3.5-snapshot-20231123103111

yarn add @medusajs/types@1.11.8-snapshot-20231123103111

yarn add @medusajs/utils@1.11.1-snapshot-20231123103111

yarn add @medusajs/workflows@0.4.0-snapshot-20231123103111

Latest commit: 4fbe02b

…hub.com/medusajs/medusa into feat/improve-create-line-item-end-point

adrien2p · 2023-11-23T11:40:45Z

/snapshot-this

github-actions · 2023-11-23T11:46:08Z

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/link-modules@0.2.4-snapshot-20231123114524

yarn add @medusajs/medusa@1.18.1-snapshot-20231123114524

yarn add @medusajs/modules-sdk@1.12.4-snapshot-20231123114524

yarn add @medusajs/orchestration@0.5.0-snapshot-20231123114524

yarn add @medusajs/pricing@0.1.5-snapshot-20231123114524

yarn add @medusajs/product@0.3.5-snapshot-20231123114524

yarn add @medusajs/types@1.11.8-snapshot-20231123114524

yarn add @medusajs/utils@1.11.1-snapshot-20231123114524

yarn add @medusajs/workflows@0.4.0-snapshot-20231123114524

Latest commit: 180b595

adrien2p · 2023-11-23T12:37:15Z

/snapshot-this

github-actions · 2023-11-23T12:42:55Z

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/ui@2.2.3-snapshot-20231123124203

yarn add @medusajs/link-modules@0.2.4-snapshot-20231123124203

yarn add @medusajs/medusa@1.18.1-snapshot-20231123124203

yarn add @medusajs/modules-sdk@1.12.4-snapshot-20231123124203

yarn add @medusajs/orchestration@0.5.0-snapshot-20231123124203

yarn add @medusajs/pricing@0.1.5-snapshot-20231123124203

yarn add @medusajs/product@0.3.5-snapshot-20231123124203

yarn add @medusajs/types@1.11.8-snapshot-20231123124203

yarn add @medusajs/utils@1.11.1-snapshot-20231123124203

yarn add @medusajs/workflows@0.4.0-snapshot-20231123124203

Latest commit: b25b29f

adrien2p · 2023-11-23T13:05:47Z

/snapshot-this

github-actions · 2023-11-23T13:11:17Z

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/ui@2.2.3-snapshot-20231123131030

yarn add @medusajs/link-modules@0.2.4-snapshot-20231123131030

yarn add @medusajs/medusa@1.18.1-snapshot-20231123131030

yarn add @medusajs/medusa-cli@1.3.22-snapshot-20231123131030

yarn add @medusajs/modules-sdk@1.12.4-snapshot-20231123131030

yarn add @medusajs/orchestration@0.5.0-snapshot-20231123131030

yarn add @medusajs/pricing@0.1.5-snapshot-20231123131030

yarn add @medusajs/product@0.3.5-snapshot-20231123131030

yarn add @medusajs/types@1.11.8-snapshot-20231123131030

yarn add @medusajs/utils@1.11.1-snapshot-20231123131030

yarn add @medusajs/workflows@0.4.0-snapshot-20231123131030

Latest commit: b25b29f

…medusajs/medusa into feat/improve-create-line-item-end-point

adrien2p · 2023-11-23T16:17:03Z

/snapshot-this

github-actions · 2023-11-23T16:24:31Z

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/admin-ui@2.1.9-snapshot-20231123162346

yarn add @medusajs/ui@2.2.3-snapshot-20231123162346

yarn add @medusajs/link-modules@0.2.4-snapshot-20231123162346

yarn add @medusajs/medusa@1.18.1-snapshot-20231123162346

yarn add @medusajs/medusa-cli@1.3.22-snapshot-20231123162346

yarn add @medusajs/modules-sdk@1.12.4-snapshot-20231123162346

yarn add @medusajs/orchestration@0.5.0-snapshot-20231123162346

yarn add @medusajs/pricing@0.1.5-snapshot-20231123162346

yarn add @medusajs/product@0.3.5-snapshot-20231123162346

yarn add @medusajs/types@1.11.8-snapshot-20231123162346

yarn add @medusajs/utils@1.11.1-snapshot-20231123162346

yarn add @medusajs/workflows@0.4.0-snapshot-20231123162346

Latest commit: 1e39a95

…medusajs/medusa into feat/improve-create-line-item-end-point

pKorsholm

LGTM! just a minor nit 😄

packages/medusa/src/strategies/cart-completion.ts

adrien2p · 2023-11-27T09:46:44Z

Before merging I am just looking at another point

olivermrbl · 2023-11-27T09:47:44Z

@adrien2p ~~do you think we should include this in the Recap release?~~

I think we should exclude this from the upcoming release, which has already been through testing. So please do not merge before 1.18.1 is out :)

adrien2p · 2023-11-27T09:50:58Z

@adrien2p do you think we should include this in the Recap release?

I think we could, especially the cluster start command wdyt?

I am also looking at some points in the create cart workflow cause there is currently multiple duplication which could be prevented. But I am just doing some tests and it would eventually be a different pr

adrien2p · 2023-11-27T10:11:33Z

@olivermrbl should we also stress the user that using the cluster in product is best practice? see

olivermrbl

LGTM, with comments. Great work :)

olivermrbl · 2023-11-30T14:59:47Z

packages/medusa-cli/src/create-cli.ts

@@ -233,6 +233,42 @@ function buildLocalCommands(cli, isLocalProject) {
        })
      ),
    })
+    .command({


comment: needs documentation

packages/medusa/src/api/routes/store/carts/create-line-item/utils/handler-steps.ts

packages/medusa/src/strategies/cart-completion.ts

packages/medusa/src/api/routes/store/carts/create-line-item/utils/handler-steps.ts

olivermrbl · 2023-12-04T14:55:59Z

/snapshot-this

github-actions · 2023-12-04T15:02:02Z

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/admin@7.1.9-snapshot-20231204150103

yarn add @medusajs/admin-ui@2.1.10-snapshot-20231204150103

yarn add @medusajs/link-modules@0.2.5-snapshot-20231204150103

yarn add @medusajs/medusa@1.19.0-snapshot-20231204150103

yarn add @medusajs/medusa-cli@1.3.22-snapshot-20231204150103

yarn add medusa-payment-klarna@1.4.0-snapshot-20231204150103

yarn add medusa-react@9.0.12-snapshot-20231204150103

yarn add @medusajs/modules-sdk@1.12.5-snapshot-20231204150103

yarn add @medusajs/pricing@0.1.6-snapshot-20231204150103

yarn add @medusajs/product@0.3.6-snapshot-20231204150103

yarn add @medusajs/utils@1.11.2-snapshot-20231204150103

Latest commit: 5d0e9ac

adrien2p added 3 commits November 23, 2023 11:17

[WIP]

dc2593b

wip

f85e7c9

wip

ba56119

adrien2p and others added 8 commits November 23, 2023 11:54

WIP

682c491

fix tests

3d1bb7d

WIP

53bd841

Merge branch 'develop' into feat/improve-create-line-item-end-point

59cd15e

feat: start-cluster cli

a7377a8

Merge branch 'feat/improve-create-line-item-end-point' of https://git…

be18f99

…hub.com/medusajs/medusa into feat/improve-create-line-item-end-point

feat: config number of cpus

b056b90

fix idem

4e22739

adrien2p added 2 commits November 23, 2023 13:36

fix step

0d7bea0

Merge branch 'develop' into feat/improve-create-line-item-end-point

ed316a4

Create tasty-ants-visit.md

f34f622

carlos-r-l-rodrigues and others added 4 commits November 23, 2023 15:41

process.env.MEDUSA_ADMIN_UI_SKIP_CACHE

d68faa7

rename var

0be0e15

finish

0e376bd

Merge branch 'feat/improve-create-line-item-end-point' of github.com:…

7c987a8

…medusajs/medusa into feat/improve-create-line-item-end-point

Merge branch 'feat/improve-create-line-item-end-point' of github.com:…

929b76c

…medusajs/medusa into feat/improve-create-line-item-end-point

olivermrbl mentioned this pull request Nov 26, 2023

perf: Endpoint /cart/:id/line-items #5693

Closed

pKorsholm approved these changes Nov 27, 2023

View reviewed changes

packages/medusa/src/strategies/cart-completion.ts Outdated Show resolved Hide resolved

address minor

21f3987

adrien2p force-pushed the feat/improve-create-line-item-end-point branch 2 times, most recently from 53da101 to 21f3987 Compare November 27, 2023 10:49

adrien2p mentioned this pull request Nov 29, 2023

feat(medusa, workflows): refactor generate line items #5148

Closed

olivermrbl approved these changes Dec 1, 2023

View reviewed changes

Address pr feedback

484efd5

olivermrbl approved these changes Dec 1, 2023

View reviewed changes

adrien2p added 3 commits December 1, 2023 16:34

missing await

fc3cb25

fix check

92d3e6f

fix check

f78471e

olivermrbl reviewed Dec 3, 2023

View reviewed changes

packages/medusa/src/api/routes/store/carts/create-line-item/utils/handler-steps.ts Outdated Show resolved Hide resolved

olivermrbl added the version: next label Dec 3, 2023

adrien2p added 2 commits December 4, 2023 09:43

fix integration

ac856f1

remove unnecessary import to non existing function anymore

1c6fc68

adrien2p requested a review from olivermrbl December 4, 2023 09:21

Merge branch 'develop' into feat/improve-create-line-item-end-point

304c3ad

olivermrbl merged commit 6975eac into develop Dec 6, 2023
15 checks passed

olivermrbl deleted the feat/improve-create-line-item-end-point branch December 6, 2023 07:53

This was referenced Dec 6, 2023

Version Packages #5754

Merged

Version Packages webbersagency/medusa#38

Open

github-actions bot mentioned this pull request Nov 27, 2023

Version Packages SGFGOV/medusa#3

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(medusa): Improve add line item to cart perf and transaction management + clustering start command #5701

feat(medusa): Improve add line item to cart perf and transaction management + clustering start command #5701

adrien2p commented Nov 23, 2023 •

edited

Loading

changeset-bot bot commented Nov 23, 2023 •

edited

Loading

vercel bot commented Nov 23, 2023 •

edited

Loading

adrien2p commented Nov 23, 2023

github-actions bot commented Nov 23, 2023

adrien2p commented Nov 23, 2023

github-actions bot commented Nov 23, 2023

adrien2p commented Nov 23, 2023

github-actions bot commented Nov 23, 2023

adrien2p commented Nov 23, 2023

github-actions bot commented Nov 23, 2023

adrien2p commented Nov 23, 2023

github-actions bot commented Nov 23, 2023

pKorsholm left a comment

adrien2p commented Nov 27, 2023

olivermrbl commented Nov 27, 2023 •

edited

Loading

adrien2p commented Nov 27, 2023

adrien2p commented Nov 27, 2023

olivermrbl left a comment

olivermrbl Nov 30, 2023

olivermrbl commented Dec 4, 2023

github-actions bot commented Dec 4, 2023

feat(medusa): Improve add line item to cart perf and transaction management + clustering start command #5701

feat(medusa): Improve add line item to cart perf and transaction management + clustering start command #5701

Conversation

adrien2p commented Nov 23, 2023 • edited Loading

changeset-bot bot commented Nov 23, 2023 • edited Loading

🦋 Changeset detected

vercel bot commented Nov 23, 2023 • edited Loading

adrien2p commented Nov 23, 2023

github-actions bot commented Nov 23, 2023

🚀 A snapshot release has been made for this PR

adrien2p commented Nov 23, 2023

github-actions bot commented Nov 23, 2023

🚀 A snapshot release has been made for this PR

adrien2p commented Nov 23, 2023

github-actions bot commented Nov 23, 2023

🚀 A snapshot release has been made for this PR

adrien2p commented Nov 23, 2023

github-actions bot commented Nov 23, 2023

🚀 A snapshot release has been made for this PR

adrien2p commented Nov 23, 2023

github-actions bot commented Nov 23, 2023

🚀 A snapshot release has been made for this PR

pKorsholm left a comment

Choose a reason for hiding this comment

adrien2p commented Nov 27, 2023

olivermrbl commented Nov 27, 2023 • edited Loading

adrien2p commented Nov 27, 2023

adrien2p commented Nov 27, 2023

olivermrbl left a comment

Choose a reason for hiding this comment

olivermrbl Nov 30, 2023

Choose a reason for hiding this comment

olivermrbl commented Dec 4, 2023

github-actions bot commented Dec 4, 2023

🚀 A snapshot release has been made for this PR

adrien2p commented Nov 23, 2023 •

edited

Loading

changeset-bot bot commented Nov 23, 2023 •

edited

Loading

vercel bot commented Nov 23, 2023 •

edited

Loading

olivermrbl commented Nov 27, 2023 •

edited

Loading