Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(medusa,pricing,types): rules only gets updated/deleted upon passing an explicit object #5711

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Nov 24, 2023

what:

  • Rules for a price list get deleted or created based on what is passed into the "rules" object of the data.
  • If no rules object is passed, we currently delete existing rules.

This PR ensures that rules are only created and deleted upon explicit passing of an object in rules.

Copy link

changeset-bot bot commented Nov 24, 2023

🦋 Changeset detected

Latest commit: 03d75c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@medusajs/pricing Patch
@medusajs/medusa Patch
@medusajs/types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2023 1:02pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2023 1:02pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2023 1:02pm

@riqwan riqwan marked this pull request as ready for review November 24, 2023 13:02
@riqwan riqwan requested review from a team as code owners November 24, 2023 13:02
Copy link
Contributor

@pKorsholm pKorsholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@olivermrbl olivermrbl merged commit fc1ef29 into develop Nov 24, 2023
12 checks passed
@olivermrbl olivermrbl deleted the fix/price-list-rules branch November 24, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants