feat(medusa, core-workflows, product): slightly improve create cart workflow #5725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 34585d7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
olivermrbl
approved these changes
Dec 6, 2023
packages/core-flows/src/handlers/customer/find-or-create-customer.ts
Outdated
Show resolved
Hide resolved
olivermrbl
reviewed
Dec 6, 2023
olivermrbl
changed the title
olivermrbl
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Improve create cart workflow, passing the entity instead of just the id when we have the entity at hand will prevent the create step to do the entire work a second time from within the cart service. The workflow have been design to split the creation into multiple steps, calling the cart service create method will also do the same step as we are currently only providing ids. On simple cart creation involving the region I got a 15% better response time from 108ms to 92ms after 600 requests for 45s