Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(medusa,pricing): fix migrations for existing databases #5730

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Nov 27, 2023

what:

  • pricing module migration is run first
  • data migration is run after
  • for the data migration to occur, the existing columns in the core need to exist, while the pricing module drops it.
  • we remove the dropping of the column from the pricing module for now as a stopgap solution.

Copy link

changeset-bot bot commented Nov 27, 2023

🦋 Changeset detected

Latest commit: c63b28f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@medusajs/pricing Patch
@medusajs/medusa Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2023 0:18am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2023 0:18am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2023 0:18am

@riqwan riqwan marked this pull request as ready for review November 27, 2023 12:28
@riqwan riqwan requested a review from a team as a code owner November 27, 2023 12:28
@olivermrbl olivermrbl merged commit 2e6b110 into develop Nov 27, 2023
15 checks passed
@olivermrbl olivermrbl deleted the fix/pricing-migration branch November 27, 2023 13:36
@github-actions github-actions bot mentioned this pull request Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants