Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use loaded module reference #5763

Merged
merged 31 commits into from
Jan 23, 2024
Merged

chore: use loaded module reference #5763

merged 31 commits into from
Jan 23, 2024

Conversation

carlos-r-l-rodrigues
Copy link
Contributor

What:

  • Medusa App can use the reference of already imported mmodules.
    Why:
  • Bundled apps need to export all the modules they will use and pass them as reference. Otherwise the tree shaking mechanism will remove them from the final bundle.

@carlos-r-l-rodrigues carlos-r-l-rodrigues requested a review from a team as a code owner November 29, 2023 11:37
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 29, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: c814544

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@medusajs/modules-sdk Patch
@medusajs/types Patch
@medusajs/pricing Patch
@medusajs/product Patch
@medusajs/inventory Patch
@medusajs/stock-location Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2024 11:09am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2024 11:09am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2024 11:09am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2024 11:09am

@carlos-r-l-rodrigues carlos-r-l-rodrigues marked this pull request as draft November 30, 2023 09:39
@carlos-r-l-rodrigues carlos-r-l-rodrigues marked this pull request as ready for review January 22, 2024 13:22
@carlos-r-l-rodrigues carlos-r-l-rodrigues requested a review from a team as a code owner January 22, 2024 13:22
adrien2p
adrien2p approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

packages/pricing/src/index.ts Outdated Show resolved Hide resolved
packages/product/src/index.ts Show resolved Hide resolved
.changeset/fuzzy-tips-clap.md Show resolved Hide resolved
@carlos-r-l-rodrigues
Copy link
Contributor Author

@olivermrbl quick cleanup to normalize what the modules are exporting + Enable MedusaApp to receive the reference of the module instead of it's path.

@carlos-r-l-rodrigues carlos-r-l-rodrigues requested a review from a team January 23, 2024 10:34
riqwan
riqwan approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

.changeset/fuzzy-tips-clap.md Outdated Show resolved Hide resolved
.changeset/fuzzy-tips-clap.md Outdated Show resolved Hide resolved
@carlos-r-l-rodrigues
Copy link
Contributor Author

@olivermrbl can I merge this one?

@olivermrbl
Copy link
Contributor

Yes, for sure!

@carlos-r-l-rodrigues carlos-r-l-rodrigues merged commit d85fee4 into develop Jan 23, 2024
16 checks passed
This was referenced Jan 23, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien2p adrien2p adrien2p approved these changes

@riqwan riqwan riqwan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carlos-r-l-rodrigues @olivermrbl @riqwan @adrien2p