-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(medusa): Respond with order when cart is already completed #5766
Conversation
🦋 Changeset detectedLatest commit: 7eac4b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
/snapshot-this |
68e98eb
to
05e3c59
Compare
05e3c59
to
cc261a9
Compare
🙏 Thanks ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/link-modules@0.2.5-snapshot-20231129154815 yarn add @medusajs/medusa@1.19.0-snapshot-20231129154815 yarn add medusa-react@9.0.12-snapshot-20231129154815 yarn add @medusajs/modules-sdk@1.12.5-snapshot-20231129154815 yarn add @medusajs/pricing@0.1.6-snapshot-20231129154815 yarn add @medusajs/product@0.3.6-snapshot-20231129154815 yarn add @medusajs/utils@1.11.2-snapshot-20231129154815
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only small nits and the topic we discussed
…/medusa into feat/complete-cart-order-on-409
a2d4b2a
to
0bb13f7
Compare
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/link-modules@0.2.5-snapshot-20231129161540 yarn add @medusajs/medusa@1.19.0-snapshot-20231129161540 yarn add medusa-react@9.0.12-snapshot-20231129161540 yarn add @medusajs/modules-sdk@1.12.5-snapshot-20231129161540 yarn add @medusajs/pricing@0.1.6-snapshot-20231129161540 yarn add @medusajs/product@0.3.6-snapshot-20231129161540 yarn add @medusajs/utils@1.11.2-snapshot-20231129161540
|
What
Hitting
POST /store/carts/:id/complete
with the ID of an already completed cart will now return the related order instead of a 409.