Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(medusa): Respond with order when cart is already completed #5766

Merged
merged 10 commits into from
Dec 1, 2023

Conversation

olivermrbl
Copy link
Contributor

@olivermrbl olivermrbl commented Nov 29, 2023

What
Hitting POST /store/carts/:id/complete with the ID of an already completed cart will now return the related order instead of a 409.

Copy link

changeset-bot bot commented Nov 29, 2023

🦋 Changeset detected

Latest commit: 7eac4b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/medusa Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@olivermrbl olivermrbl requested a review from adrien2p November 29, 2023 14:12
Copy link

vercel bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2023 4:10pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2023 4:10pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2023 4:10pm

@olivermrbl
Copy link
Contributor Author

/snapshot-this

@olivermrbl olivermrbl force-pushed the feat/complete-cart-order-on-409 branch from 68e98eb to 05e3c59 Compare November 29, 2023 14:12
@olivermrbl olivermrbl force-pushed the feat/complete-cart-order-on-409 branch from 05e3c59 to cc261a9 Compare November 29, 2023 14:13
@bqst
Copy link
Contributor

bqst commented Nov 29, 2023

🙏 Thanks !

Copy link
Contributor

@kasperkristensen kasperkristensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olivermrbl
Copy link
Contributor Author

/snapshot-this

Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/link-modules@0.2.5-snapshot-20231129154815
yarn add @medusajs/medusa@1.19.0-snapshot-20231129154815
yarn add medusa-react@9.0.12-snapshot-20231129154815
yarn add @medusajs/modules-sdk@1.12.5-snapshot-20231129154815
yarn add @medusajs/pricing@0.1.6-snapshot-20231129154815
yarn add @medusajs/product@0.3.6-snapshot-20231129154815
yarn add @medusajs/utils@1.11.2-snapshot-20231129154815

Latest commit: 4e9d954

Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only small nits and the topic we discussed

integration-tests/api/__tests__/store/orders.js Outdated Show resolved Hide resolved
integration-tests/api/__tests__/store/orders.js Outdated Show resolved Hide resolved
packages/product/src/services/product-module-service.ts Outdated Show resolved Hide resolved
@olivermrbl olivermrbl force-pushed the feat/complete-cart-order-on-409 branch from a2d4b2a to 0bb13f7 Compare November 29, 2023 16:09
@olivermrbl
Copy link
Contributor Author

/snapshot-this

Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/link-modules@0.2.5-snapshot-20231129161540
yarn add @medusajs/medusa@1.19.0-snapshot-20231129161540
yarn add medusa-react@9.0.12-snapshot-20231129161540
yarn add @medusajs/modules-sdk@1.12.5-snapshot-20231129161540
yarn add @medusajs/pricing@0.1.6-snapshot-20231129161540
yarn add @medusajs/product@0.3.6-snapshot-20231129161540
yarn add @medusajs/utils@1.11.2-snapshot-20231129161540

Latest commit: 4e9d954

@olivermrbl olivermrbl merged commit 428331a into develop Dec 1, 2023
15 checks passed
@olivermrbl olivermrbl deleted the feat/complete-cart-order-on-409 branch December 1, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants