-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Emit "discount.created" event when discount is created #5816
Feature: Emit "discount.created" event when discount is created #5816
Conversation
🦋 Changeset detectedLatest commit: 0188efd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@Arsenalist is attempting to deploy a commit to the medusajs Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution
can I get you to fix the conflicts? 😄
Could I get you to add a changeset with a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only one suggestion and waiting shahed response
Merge branch 'develop' of https://github.com/medusajs/medusa into feat/add-promo-code-added-event
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Arsenalist let's remove the doc changes for now, as it will appear in the docs once the PR is merged, even if it's not released yet. I'll add it in after the release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can alternatively add it in another PR that we merge once the release is out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Arsenalist let's remove the doc changes for now, as it will appear in the docs once the PR is merged, even if it's not released yet. I'll add it in after the release
Hi, I have removed the doc changes. Will create another PR after it has been released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great if you can create the PR now so that we can have it ready for release, and we'll merge it in time 😇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great if you can create the PR now so that we can have it ready for release, and we'll merge it in time 😇
No problem, here it is: #5850
This reverts commit 9447f4a.
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
Whenever a discount is created, emit an event.