Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Emit "discount.created" event when discount is created #5816

Merged

Conversation

Arsenalist
Copy link
Contributor

Whenever a discount is created, emit an event.

@Arsenalist Arsenalist requested review from a team as code owners December 6, 2023 22:14
Copy link

changeset-bot bot commented Dec 6, 2023

🦋 Changeset detected

Latest commit: 0188efd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/medusa Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 6, 2023

@Arsenalist is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@pKorsholm pKorsholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution

can I get you to fix the conflicts? 😄

@pKorsholm pKorsholm requested a review from adrien2p December 8, 2023 06:52
@pKorsholm
Copy link
Contributor

Could I get you to add a changeset with a patch?

Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one suggestion and waiting shahed response

packages/medusa/src/services/__tests__/discount.js Outdated Show resolved Hide resolved
www/docs/content/development/events/events-list.md Outdated Show resolved Hide resolved
Merge branch 'develop' of https://github.com/medusajs/medusa into feat/add-promo-code-added-event
@Arsenalist
Copy link
Contributor Author

Could I get you to add a changeset with a patch?

Done.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Arsenalist let's remove the doc changes for now, as it will appear in the docs once the PR is merged, even if it's not released yet. I'll add it in after the release

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can alternatively add it in another PR that we merge once the release is out

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Arsenalist let's remove the doc changes for now, as it will appear in the docs once the PR is merged, even if it's not released yet. I'll add it in after the release

Hi, I have removed the doc changes. Will create another PR after it has been released.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great if you can create the PR now so that we can have it ready for release, and we'll merge it in time 😇

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great if you can create the PR now so that we can have it ready for release, and we'll merge it in time 😇

No problem, here it is: #5850

Copy link

vercel bot commented Dec 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2023 9:49am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2023 9:49am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2023 9:49am

@olivermrbl olivermrbl merged commit 6f96ced into medusajs:develop Dec 12, 2023
15 checks passed
@github-actions github-actions bot mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants