Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed 'duplicate' to 'delete' in "Delete a Variant" Section #5823

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Changed 'duplicate' to 'delete' in "Delete a Variant" Section #5823

merged 2 commits into from
Dec 18, 2023

Conversation

IdekDude
Copy link
Contributor

@IdekDude IdekDude commented Dec 7, 2023 •
edited
Loading

References Issue 5787

@IdekDude IdekDude requested a review from a team as a code owner December 7, 2023 17:03
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 7, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 20fcaeb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Dec 7, 2023

@IdekDude is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

shahednasser
shahednasser approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @IdekDude

@kodiakhq kodiakhq bot merged commit 25dd570 into medusajs:develop Dec 18, 2023
16 of 19 checks passed
@IdekDude IdekDude deleted the patch-1 branch December 22, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahednasser shahednasser shahednasser approved these changes

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IdekDude @shahednasser @riqwan