Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin-ui): Bulk editor default fields #5829

Merged
merged 4 commits into from
Dec 10, 2023

Conversation

kasperkristensen
Copy link
Contributor

What

  • For new products with no prices the Bulk Editor in product details would not have any fields by default. This PR changes that so when first opening the modal if a product has no prices, then the fields for the store's currencies will be visible.
  • Also changes the label of the currency selector dropdown in both Bulk Editors to "Currencies" for more clarity.

@kasperkristensen kasperkristensen requested a review from a team as a code owner December 8, 2023 14:49
Copy link

changeset-bot bot commented Dec 8, 2023

⚠️ No Changeset found

Latest commit: 89faaac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Dec 8, 2023 2:49pm
docs-ui ⬜️ Ignored (Inspect) Dec 8, 2023 2:49pm
medusa-docs ⬜️ Ignored (Inspect) Dec 8, 2023 2:49pm

Copy link
Contributor

@fPolic fPolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@olivermrbl olivermrbl merged commit 8ab5baf into develop Dec 10, 2023
15 checks passed
@olivermrbl olivermrbl deleted the fix/bulk-editor-default-fields branch December 10, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants