Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(medusa): add currency to region responses #5857

Merged
merged 9 commits into from
Dec 14, 2023

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Dec 13, 2023

Resolves #5837

Copy link

vercel bot commented Dec 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2023 3:45pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2023 3:45pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2023 3:45pm

Copy link

changeset-bot bot commented Dec 13, 2023

🦋 Changeset detected

Latest commit: f17efbf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/medusa Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@riqwan riqwan marked this pull request as ready for review December 13, 2023 12:08
@riqwan riqwan requested a review from a team as a code owner December 13, 2023 12:08
@riqwan riqwan changed the title chore(medusa): add currency to region responses feat(medusa): add currency to region responses Dec 13, 2023
Copy link
Contributor

@pKorsholm pKorsholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just have a comment in the integration tests

integration-tests/api/package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very nice clean up too!

@kodiakhq kodiakhq bot merged commit 2d79eee into develop Dec 14, 2023
15 checks passed
@kodiakhq kodiakhq bot deleted the feat/add-currency-to-region branch December 14, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Region response in medusa-react is missing the "Currency" property
3 participants