Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: updates for v1.19 #5868

Merged
merged 3 commits into from
Dec 14, 2023
Merged

docs: updates for v1.19 #5868

merged 3 commits into from
Dec 14, 2023

Conversation

shahednasser
Copy link
Member

  • Added docs for start-cluster command
  • Added maxRetries option to Medusa React docs
  • Added Upgrade Guide for v1.19
  • General fixes/improvements

@shahednasser shahednasser requested a review from a team as a code owner December 14, 2023 09:18
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 14, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0517d64

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Dec 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2023 1:12pm
docs-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2023 1:12pm
medusa-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2023 1:12pm

olivermrbl
olivermrbl approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a couple of suggestions to wording

www/apps/docs/content/upgrade-guides/medusa-core/1-19.mdx Outdated Show resolved Hide resolved
www/apps/docs/content/upgrade-guides/medusa-core/1-19.mdx Outdated Show resolved Hide resolved
shahednasser and others added 2 commits December 14, 2023 14:59
@shahednasser @olivermrbl
Update www/apps/docs/content/upgrade-guides/medusa-core/1-19.mdx
4c0ef8b 
Co-authored-by: Oli Juhl <59018053+olivermrbl@users.noreply.github.com>
@shahednasser @olivermrbl
Update www/apps/docs/content/upgrade-guides/medusa-core/1-19.mdx
0517d64 
Co-authored-by: Oli Juhl <59018053+olivermrbl@users.noreply.github.com>
@olivermrbl olivermrbl merged commit a6c8490 into develop Dec 14, 2023
21 checks passed
@olivermrbl olivermrbl deleted the docs/1.19-changes branch December 14, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

Assignees
No one assigned
Labels
version: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shahednasser @olivermrbl