Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Typo in documentation #5921

Closed
wants to merge 1 commit into from
Closed

fix: Typo in documentation #5921

wants to merge 1 commit into from

Conversation

aldo-roman
Copy link
Contributor

Expendable -> Expandable

@aldo-roman
fix: Typo in documentation
44daf1d 
Expendable -> Expandable
@aldo-roman aldo-roman requested a review from a team as a code owner December 18, 2023 14:44
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2023

⚠️ No Changeset found

Latest commit: 44daf1d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Dec 18, 2023

@aldo-roman is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

shahednasser
shahednasser requested changes Dec 19, 2023
View reviewed changes
Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can you change the PR branch name to start with docs/? Otherwise documentation tests won't run

@aldo-roman aldo-roman closed this Dec 19, 2023
@aldo-roman aldo-roman deleted the patch-1 branch December 19, 2023 16:12
@aldo-roman
Copy link
Contributor Author

It seems renaming closed this PR.

Continuing in #5933

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahednasser shahednasser shahednasser requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aldo-roman @shahednasser