Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(medusa-js): remove unnecessary query field in AdminInventoryItemsResource.deleteLocationLevel method #5941

Merged
merged 4 commits into from
Dec 21, 2023

Conversation

shahednasser
Copy link
Member

@shahednasser shahednasser commented Dec 20, 2023

What

The underlying endpoint /admin/inventory-items/{id}/location-levels/{location_id} that the JS Client's AdminInventoryItemsResource.deleteLocationLevel method sends a request to doesn't accept query parameters. So, the query argument of the deleteLocationLevel is unnecessary.

Fixes CORE-1550

@shahednasser shahednasser requested a review from a team as a code owner December 20, 2023 10:49
Copy link

changeset-bot bot commented Dec 20, 2023

🦋 Changeset detected

Latest commit: 3849d5c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/medusa-js Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Dec 21, 2023 2:26pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Dec 21, 2023 2:26pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Dec 21, 2023 2:26pm

@kodiakhq kodiakhq bot merged commit bfd10da into develop Dec 21, 2023
15 checks passed
@kodiakhq kodiakhq bot deleted the fix/core-1550 branch December 21, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants