fix(medusa): Resolve babel executable with npx
#5952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a3214e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
|
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/admin-ui@2.1.11-snapshot-20231221111816yarn add @medusajs/authentication@0.0.1yarn add @medusajs/link-modules@0.2.6-snapshot-20231221111816yarn add @medusajs/medusa@1.19.1-snapshot-20231221111816yarn add medusa-fulfillment-manual@1.1.39-snapshot-20231221111816yarn add medusa-fulfillment-webshipper@1.4.2-snapshot-20231221111816yarn add medusa-interfaces@1.3.8-snapshot-20231221111816yarn add @medusajs/medusa-js@6.1.5-snapshot-20231221111816yarn add medusa-payment-adyen@1.1.45-snapshot-20231221111816yarn add @medusajs/modules-sdk@1.12.6-snapshot-20231221111816yarn add @medusajs/orchestration@0.5.2-snapshot-20231221111816yarn add @medusajs/pricing@0.1.7-snapshot-20231221111816yarn add @medusajs/promotion@0.0.1yarn add @medusajs/types@1.11.10-snapshot-20231221111816yarn add @medusajs/utils@1.11.3-snapshot-20231221111816yarn add @medusajs/workflows-sdk@0.1.1-snapshot-20231221111816
|
|
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/admin-ui@2.1.11-snapshot-20231221132615yarn add @medusajs/link-modules@0.2.6-snapshot-20231221132615yarn add @medusajs/medusa@1.19.1-snapshot-20231221132615yarn add medusa-fulfillment-manual@1.1.39-snapshot-20231221132615yarn add medusa-fulfillment-webshipper@1.4.2-snapshot-20231221132615yarn add medusa-interfaces@1.3.8-snapshot-20231221132615yarn add @medusajs/medusa-js@6.1.5-snapshot-20231221132615yarn add medusa-payment-adyen@1.1.45-snapshot-20231221132615yarn add @medusajs/modules-sdk@1.12.6-snapshot-20231221132615yarn add @medusajs/orchestration@0.5.2-snapshot-20231221132615yarn add @medusajs/pricing@0.1.7-snapshot-20231221132615yarn add @medusajs/types@1.11.10-snapshot-20231221132615yarn add @medusajs/utils@1.11.3-snapshot-20231221132615yarn add @medusajs/workflows-sdk@0.1.1-snapshot-20231221132615
|
olivermrbl
force-pushed
the
fix/develop-command
branch
from
6f016b1 to
0c1bca2
Compare
|
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/admin-ui@2.1.11-snapshot-20231221133510yarn add @medusajs/link-modules@0.2.6-snapshot-20231221133510yarn add @medusajs/medusa@1.19.1-snapshot-20231221133510yarn add medusa-fulfillment-manual@1.1.39-snapshot-20231221133510yarn add medusa-fulfillment-webshipper@1.4.2-snapshot-20231221133510yarn add medusa-interfaces@1.3.8-snapshot-20231221133510yarn add @medusajs/medusa-js@6.1.5-snapshot-20231221133510yarn add medusa-payment-adyen@1.1.45-snapshot-20231221133510yarn add @medusajs/modules-sdk@1.12.6-snapshot-20231221133510yarn add @medusajs/orchestration@0.5.2-snapshot-20231221133510yarn add @medusajs/pricing@0.1.7-snapshot-20231221133510yarn add @medusajs/types@1.11.10-snapshot-20231221133510yarn add @medusajs/utils@1.11.3-snapshot-20231221133510yarn add @medusajs/workflows-sdk@0.1.1-snapshot-20231221133510
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use
npxto resolve the correct babel binary executableWhy
In https://github.com/medusajs/medusa/pull/5723/files, we introduced a new best guess method for where to find the babel executable in an attempt to improve monorepo usage. However, it turned out to introduce issues on Windows as evident from #5905.
How
npxautomatically resolves the correct executable from the nearest node_modules/.bin directory, starting from the current working directory and moving up the directory hierarchy.npxshould work in simple repositories as well as monorepos – at least using the most popular monorepo tools like workspaces, nx, turborepo, etc.