Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflows-sdk): Allow primitive values to be passed as well as WorkflowDataProperties #5953

Merged
merged 4 commits into from
Dec 22, 2023

Conversation

adrien2p
Copy link
Member

What
Allow to pass plain value and WorkflowDataProperty to a step

Copy link

changeset-bot bot commented Dec 21, 2023

🦋 Changeset detected

Latest commit: a6d9782

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/workflows-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Dec 21, 2023 4:05pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Dec 21, 2023 4:05pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Dec 21, 2023 4:05pm

@adrien2p
Copy link
Member Author

@olivermrbl wdyt? We can now mix plain values and WorkflowDataProperty as we discussed. Now steps input can always accept both types, the wrapped one or the plain one

@olivermrbl
Copy link
Contributor

Nice, will give it a spin!

@olivermrbl
Copy link
Contributor

/snapshot-this

Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/admin-ui@2.1.11-snapshot-20231221151121
yarn add @medusajs/link-modules@0.2.6-snapshot-20231221151121
yarn add @medusajs/medusa@1.19.1-snapshot-20231221151121
yarn add medusa-fulfillment-manual@1.1.39-snapshot-20231221151121
yarn add medusa-fulfillment-webshipper@1.4.2-snapshot-20231221151121
yarn add medusa-interfaces@1.3.8-snapshot-20231221151121
yarn add @medusajs/medusa-js@6.1.5-snapshot-20231221151121
yarn add medusa-payment-adyen@1.1.45-snapshot-20231221151121
yarn add @medusajs/modules-sdk@1.12.6-snapshot-20231221151121
yarn add @medusajs/orchestration@0.5.2-snapshot-20231221151121
yarn add @medusajs/pricing@0.1.7-snapshot-20231221151121
yarn add @medusajs/types@1.11.10-snapshot-20231221151121
yarn add @medusajs/utils@1.11.3-snapshot-20231221151121
yarn add @medusajs/workflows-sdk@0.1.1-snapshot-20231221151121

Latest commit: bfd10da

@adrien2p adrien2p marked this pull request as ready for review December 21, 2023 16:05
@adrien2p adrien2p requested a review from a team as a code owner December 21, 2023 16:05
@olivermrbl olivermrbl merged commit a0dd18c into develop Dec 22, 2023
15 checks passed
@olivermrbl olivermrbl deleted the feat/workflows-sdk-primitive-value-support branch December 22, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants